Skip to content

docs: translate useSyncExternalStore hook #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 4, 2023
Merged

docs: translate useSyncExternalStore hook #506

merged 10 commits into from
May 4, 2023

Conversation

samnap11
Copy link
Contributor

Closes #410

Description

Translate the useSyncExternalStore page.
Page URL: https://id.react.dev/reference/react/useSyncExternalStore

@samnap11 samnap11 marked this pull request as draft April 29, 2023 14:56
@github-actions
Copy link

github-actions bot commented Apr 29, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@samnap11
Copy link
Contributor Author

Should I translate snapshot to Indonesian or leave it as-is?

@samnap11 samnap11 force-pushed the useSyncExternalStore branch from 303f478 to 04c6223 Compare April 29, 2023 16:43
@samnap11 samnap11 marked this pull request as ready for review April 29, 2023 16:43
@mhaidarhanif
Copy link
Collaborator

@samnap11 Let's keep it as snapshot

mhaidarhanif
mhaidarhanif requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

mazipan
mazipan reviewed Apr 30, 2023
View reviewed changes
src/content/reference/react/useSyncExternalStore.md Outdated

#### Caveats {/*caveats*/}
#### Perhatian {/*caveats*/}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pakai Caveat aja

Suggested change
#### Perhatian {/*caveats*/}
#### Caveats {/*caveats*/}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ini sepertinya harus ditambahkan di Glosarium karena saya sebenarnya memutuskan untuk menerjemahkan ini dari salah satu halaman yang ada.

id.react.dev/src/content/reference/react/useRef.md

Line 48 in 362e8e8

#### Perhatian {/*caveats*/}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 Yes, needs to be discussed and confirmed to the glossary: #337

cc @mazipan @r17x @resir014 @zainfathoni

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 sudah update untuk diskusi mengenain ceveats, lihat disini #337 (comment).

Boleh diubah yah!

@samnap11 samnap11 force-pushed the useSyncExternalStore branch from a0992a3 to e105cfc Compare April 30, 2023 09:41
@mhaidarhanif
Copy link
Collaborator

Should be fine but let's wait for the others. @resir014 @r17x @mazipan @zainfathoni

resir014
resir014 requested changes May 1, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnap11 Some suggested changes:

@samnap11 samnap11 force-pushed the useSyncExternalStore branch from 7d6fd3b to e9552b2 Compare May 1, 2023 13:15
@samnap11 samnap11 requested a review from resir014 May 1, 2023 13:16
mazipan
mazipan approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mazipan
Copy link
Collaborator

mazipan commented May 3, 2023

Waiting approval from @resir014

resir014
resir014 approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@resir014 resir014 merged commit 894ba27 into reactjs:main May 4, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@samnap11 @mhaidarhanif
@mazipan @r17x
docs: translate useSyncExternalStore hook (#506)
3b4462f 
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@r17x r17x r17x approved these changes

@resir014 resir014 resir014 approved these changes

@mazipan mazipan mazipan approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useSyncExternalStore
6 participants
@samnap11 @mhaidarhanif @mazipan @resir014 @zainfathoni @r17x