Update jsdocs for hooks #1295
Merged
Update jsdocs for hooks #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 5328a55 |
trappar
changed the title
|
What IDE are you using? |
|
Webstorm. This will be the case in all IntelliJ IDEs though. |
|
Okay, seems reasonable. |
timdorr
pushed a commit
that referenced
this pull request
May 30, 2019
* Make second argument to useSelector optional * Update useDispatch jsdoc return
timdorr
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Make second argument to useSelector optional * Update useDispatch jsdoc return
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* Make second argument to useSelector optional * Update useDispatch jsdoc return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useSelector: Not having the second argument be optional in the jsdoc is making my IDE complain "Invalid number of arguments, expected 2"
useDispatch: My IDE sees this {any} return value and doesn't assume it can be called. I get "Method expression is not of function type". Suggesting it might be a function seems safe enough.