Skip to content

docs(hooks): clarify useSelector re-runs on render #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

AndersDJohnson
Copy link
Contributor

The documentation on useSelector was a little unclear as to when it re-runs on function component renders. It does not seem to re-run on re-renders when a selector reference doesn't change (as was hinted at below, but not above).

@netlify
Copy link

netlify bot commented Feb 22, 2020

Deploy preview for react-redux-docs ready!

Built with commit 112cd69

https://deploy-preview-1526--react-redux-docs.netlify.com

@netlify
Copy link

netlify bot commented Feb 22, 2020

Deploy preview for react-redux-docs ready!

Built with commit 579415c

https://deploy-preview-1526--react-redux-docs.netlify.com

@markerikson
Copy link
Contributor

Thanks. Unfortunately, due to how we version the docs, this will only show up in the "Next" version section, and not the "7.1" version section. Can you update the matching file under versioned_docs as well?

@AndersDJohnson
Copy link
Contributor Author

Thanks. Unfortunately, due to how we version the docs, this will only show up in the "Next" version section, and not the "7.1" version section. Can you update the matching file under versioned_docs as well?

@markerikson Good call. Done in 579415c!

@markerikson
Copy link
Contributor

Yeah, I'm still really not happy with how versioning gets handled in Docusaurus, and I don't think it gets any better in v2. This is exactly my concern with it - folks don't know to edit the versioned_docs files, and the /docs folder is actually "next" and not "current".

Thanks!

@markerikson markerikson merged commit 043517e into reduxjs:master Feb 22, 2020
@AndersDJohnson AndersDJohnson deleted the patch-1 branch February 22, 2020 20:50
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* docs(hooks): clarify useSelector re-runs on render

* Update hooks.md

* update versioned_docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants