Regression in 2.10.0: `no implicit conversion of false into Proc (TypeError)`

[myronmarston]

I'm seeing a new exception from the recently released 2.10.0.

To reproduce, put this in a script:

require "bundler/inline"

gemfile do
  source "https://rubygems.org"
  gem "json", ENV.fetch("JSON_VERSION")
end

require "json"

puts({query: {match_all: {}}}.to_json(as_json: false))

Then run it:

$ JSON_VERSION=2.9.1 ruby json_bug.rb
{"query":{"match_all":{}}}
$ JSON_VERSION=2.10.0 ruby json_bug.rb
/Users/myron/.rvm/gems/ruby-3.3.4/gems/json-2.10.0/lib/json/ext/generator/state.rb:45:in `_configure': no implicit conversion of false into Proc (TypeError)

          _configure(opts)
                     ^^^^
        from /Users/myron/.rvm/gems/ruby-3.3.4/gems/json-2.10.0/lib/json/ext/generator/state.rb:45:in `configure'
        from /Users/myron/.rvm/gems/ruby-3.3.4/gems/json-2.10.0/lib/json/ext/generator/state.rb:27:in `initialize'
        from json_bug.rb:10:in `new'
        from json_bug.rb:10:in `to_json'
        from json_bug.rb:10:in `<main>'

[byroot]

Thanks.

That's because as_json: is now an accepted parameter and it's expected to be a proc.

Not too sure what you were passing it for? Is this something used in your own implementations of def to_json?

[myronmarston]

I'm not intending to pass as_json: anywhere. My project uses the OpenSearch Ruby client, which in turn uses multi_json, which winds up calling to_json with as_json: false. I grepped both codebases for as_json and don't see it anywhere, but it appears that multi_json is getting it from ::JSON::PRETTY_STATE_PROTOTYPE.to_h when the OpenSearch gem passes pretty: true:

https://github.com/intridea/multi_json/blob/v1.15.0/lib/multi_json/adapters/json_common.rb#L18

[byroot]

Thank you for this information, that allowed me to figure out the problem:

JSON::State.new(JSON::State.new.to_h)

I'll fix it.

[byroot]

2.10.1 is out with the fix.

[myronmarston]

Thanks for the quick fix!