Skip to content

prevent ice when threshold is 0 and enum has no variants #11552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2023
Merged

prevent ice when threshold is 0 and enum has no variants #11552

merged 3 commits into from
Sep 24, 2023

Conversation

jonboh
Copy link
Contributor

@jonboh jonboh commented Sep 22, 2023 •
edited
Loading

changelog: [enum_variant_names]: prevent ice when threshold is 0 and enum has no variants

r? @y21

Fixes the same ice issue raised during review of #11496

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

Failed to set assignee to y21: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 22, 2023
@jonboh jonboh mentioned this pull request Sep 22, 2023
Merged
@y21
Copy link
Member

y21 commented Sep 22, 2023

Can we have a test for this? Might be a good time now to create tests/ui-toml/crashes, which would be similar to the already existing tests/ui/crashes, but for ICEs that need a toml file

r? @Alexendoo (can I do this? let's find out)

@jonboh
Copy link
Contributor Author

jonboh commented Sep 24, 2023

I'll merge and rename the ui-toml test on #11496 once this is merged.

y21
y21 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me! Just one small thing

@Alexendoo
Copy link
Member

@bors delegate=y21

@bors
Copy link
Contributor

bors commented Sep 24, 2023

✌️ @y21, you can now approve this pull request!

If @Alexendoo told you to "r=me" after making some further change, please make that change, then do @bors r=@Alexendoo

@jonboh @y21
use first instead of get(0)
0433e45 
Co-authored-by: Timo <30553356+y21@users.noreply.github.com>
@y21
Copy link
Member

y21 commented Sep 24, 2023

Thanks for the fix!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2023

📌 Commit 0433e45 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2023

⌛ Testing commit 0433e45 with merge c9c031c...

bors added a commit that referenced this pull request Sep 24, 2023
@bors
Auto merge of #11552 - jonboh:ice_threshold_0_enum_variants, r=y21
c9c031c 
prevent ice when threshold is 0 and enum has no variants

changelog: [`lint_name`]: prevent ice when threshold is 0 and enum has no variants

r? `@y21`

Fixes the same ice issue raised during review of #11496
@y21
Copy link
Member

y21 commented Sep 24, 2023

@bors r-
I just saw the changelog. Looks like you forgot to add the lint name ^^

@bors
Copy link
Contributor

bors commented Sep 24, 2023

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: c9c031c (c9c031c31e0cdb440fef29661061111a617d621e)

@jonboh
Copy link
Contributor Author

jonboh commented Sep 24, 2023

wops, fixed now

@y21
Copy link
Member

y21 commented Sep 24, 2023

Thanks again!👍
@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2023

📌 Commit 0433e45 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2023

⌛ Testing commit 0433e45 with merge aa137a7...

@bors
Copy link
Contributor

bors commented Sep 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing aa137a7 to master...

@bors bors merged commit aa137a7 into rust-lang:master Sep 24, 2023
@bors bors mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@Alexendoo Alexendoo

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonboh @rustbot @y21 @Alexendoo @bors