Rustdoc: Search help keybind `?` does nothing

[bluss]

Typing ? in rustdoc doesn't do anything. Probably a keyboard layout issue. S works fine.

Platform: Firefox or Chromium, Linux x86-64.

Keyboard layout: Swedish.

My ? is under Shift-+.

[Gankra]

It's working for me in Firefox on OSX, what're you seeing this in?

[bluss]

Updated. I think it's hardcoded to US keylayout or so.

[Gankra]

Yep:

https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/main.js#L84-L85

        if (e.which === 191) { // question mark
            if (e.shiftKey && $('#help').hasClass('hidden')) {

[Gankra]

@bluss Can you pull up your browser's JS console (ctrl+shift+k on firefox, ctrl+shift+j on chromium in linux iirc) and paste in this code snippet:

document.addEventListener('keypress', function(e) { if (e.key === "?") { console.log("Yes!"); } });

(it's a REPL, so you need to hit enter)

click back on the page, type ? and tell me if the console prints "Yes!" or not?

[bluss]

Sure, thanks for the steps. Firefox: It says "Yes!", chromium: Nothing happens.

[bluss]

My 5 minutes of experience with javascript tells me e.char or e.charCode should be preferred. In chrome & firefox, charCode gives 63 which is the ascii encoding of ?.

[Gankra]

These are in an awesome limbo state of the old way being deprecated and the new way being unimplemented. We'll probably have to test a few ways and pray.

[Gankra]

Some data: https://gist.github.com/anonymous/f95c0f4526fbceb201b4

[Gankra]

Discussing it on IRC, it looks like e.key should indeed be preferred with which or keyCode used as a "legacy fallback". I'm a bit busy focusing on getting collections stuff fixed up. I'm willing to mentor anyone who wants to get a try at working on rustdoc stuff.

[klnusbaum]

I think I know a good way to do this. Looking at this it would appear you can actually function called String.fromCharCode to get the key that was pressed in string form and then compare on that. Let me give it a shot.

[klnusbaum]

Actually this looks even better.