dirfd: preliminary unix and windows implementations #139514

Qelxiros · 2025-04-08T05:45:01Z

Tracking issue: #120426

As per this comment, this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks!

try-job: x86_64-msvc*
try-job: test-various*
try-job: dist-various*

rustbot · 2025-04-08T05:45:06Z

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-04-28T08:50:33Z

r? libs

library/std/src/fs.rs

library/std/src/sys/fs/unix.rs

library/std/src/fs.rs

library/std/src/sys/fs/unix.rs

bors · 2025-05-03T11:34:31Z

☔ The latest upstream changes (presumably #140608) made this pull request unmergeable. Please resolve the merge conflicts.

Qelxiros · 2025-05-22T22:37:05Z

@tgross35 This has been waiting for a review for two weeks. Should I reroll another reviewer? I'm not sure what the process is here, but I don't want it to slip through the cracks. Is this PR mergeable in it's current state or is there something more I need to implement? Obviously there are more functions in the ACP, but I want to make sure I'm on the right track with what I have.

ChrisDenton

Sorry for the delay, quite a lot of us were away for a week+. I can take an initial look at the Windows code.

library/std/src/sys/fs/windows.rs

Qelxiros · 2025-05-24T02:18:41Z

All good on the delay, and thanks for the review! Those issues should be good now. As a side note to whoever does the next review, there have been a lot of changes on the unix side too since the last review.

Qelxiros · 2025-06-07T16:42:29Z

@tgross35 are you able to review this?

tgross35 · 2025-06-11T01:59:40Z

@bors2 try

rust-bors · 2025-06-11T01:59:44Z

⌛ Trying commit f4d6ffc with merge 17a8062…

To cancel the try build, run the command @bors2 try cancel.

dirfd: preliminary unix and windows implementations Tracking issue: #120426 As per [this comment](#120426 (comment)), this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks! try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

rust-bors · 2025-06-11T02:43:41Z

💔 Test failed

CI ❌

Qelxiros · 2025-06-11T04:46:51Z

The default checks aren't useful for testing other platforms.

@bors2 try

rust-bors · 2025-06-11T04:46:54Z

@Qelxiros: 🔑 Insufficient privileges: not in try users

tgross35 · 2025-06-11T04:49:44Z

@bors2 try

dirfd: preliminary unix and windows implementations Tracking issue: #120426 As per [this comment](#120426 (comment)), this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks! try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

rust-bors · 2025-06-11T04:49:48Z

⌛ Trying commit d4a9a2b with merge 8b59c72…

To cancel the try build, run the command @bors2 try cancel.

rust-bors · 2025-06-11T05:33:40Z

💔 Test failed

CI ❌

Qelxiros · 2025-06-11T06:04:06Z

@tgross35 I think it'll work now, if you want to try again (pun intended).

library/std/src/fs.rs

library/std/src/sys/fs/unsupported.rs

library/std/src/sys/fs/unix.rs

library/std/src/fs.rs

library/std/src/sys/fs/unix.rs

Qelxiros · 2025-06-20T04:59:25Z

@tgross35 @the8472 could I get a bors try? The Unix imports are a bit of a mess, and I think they might be wrong somewhere, but I'm not sure.

the8472 · 2025-06-21T10:29:08Z

@bors2 try

rust-bors · 2025-06-21T10:29:12Z

⌛ Trying commit 24568f9 with merge e4c28d7…

To cancel the try build, run the command @bors2 try cancel.

dirfd: preliminary unix and windows implementations Tracking issue: #120426 As per [this comment](#120426 (comment)), this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks! try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

rust-bors · 2025-06-21T11:29:33Z

💔 Test failed

CI ❌

rustbot assigned workingjubilee Apr 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 8, 2025

This comment has been minimized.

Sign in to view

rustbot assigned tgross35 and unassigned workingjubilee Apr 28, 2025

tgross35 requested changes May 1, 2025

View reviewed changes

library/std/src/fs.rs Outdated Show resolved Hide resolved

library/std/src/fs.rs Outdated Show resolved Hide resolved

library/std/src/fs.rs Outdated Show resolved Hide resolved

library/std/src/sys/fs/unix.rs Outdated Show resolved Hide resolved

library/std/src/fs.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025

Noratrieb reviewed May 2, 2025

View reviewed changes

library/std/src/sys/fs/unix.rs Outdated Show resolved Hide resolved

Qelxiros force-pushed the 120426-dirfd branch from 20ff465 to 4691b25 Compare May 3, 2025 16:04

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the 120426-dirfd branch from fb4e8d3 to 2e182a0 Compare May 6, 2025 01:57

This comment has been minimized.

Sign in to view

Qelxiros changed the title ~~dirfd: initial quick and dirty implementation for unix~~ dirfd: preliminary unix and windows implementations May 6, 2025

Qelxiros requested review from Noratrieb and tgross35 May 6, 2025 04:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2025

ChrisDenton reviewed May 23, 2025

View reviewed changes

library/std/src/sys/fs/windows.rs Outdated Show resolved Hide resolved

library/std/src/sys/fs/windows.rs Outdated Show resolved Hide resolved

library/std/src/sys/fs/windows.rs Outdated Show resolved Hide resolved

library/std/src/sys/fs/windows.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

tgross35 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 11, 2025

Qelxiros requested a review from tgross35 June 11, 2025 04:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025

add unsupported implementations for missing platforms

02f9073

Qelxiros force-pushed the 120426-dirfd branch from d4a9a2b to 02f9073 Compare June 11, 2025 05:41

the8472 reviewed Jun 11, 2025

View reviewed changes

Qelxiros added 2 commits June 11, 2025 22:33

add pathbuf implementation to common

9ae1e46

requested changes

f07f7c5

This comment has been minimized.

Sign in to view

add DirEntry API, fixes for other platforms

24568f9

Qelxiros force-pushed the 120426-dirfd branch from 2ea12f6 to 24568f9 Compare June 20, 2025 03:06

Qelxiros requested review from the8472 and ChrisDenton June 20, 2025 19:53

dirfd: preliminary unix and windows implementations #139514

Are you sure you want to change the base?

dirfd: preliminary unix and windows implementations #139514

Conversation

Qelxiros commented Apr 8, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 8, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented May 3, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Qelxiros commented May 22, 2025

Uh oh!

ChrisDenton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Qelxiros commented May 24, 2025

Uh oh!

Qelxiros commented Jun 7, 2025

Uh oh!

tgross35 commented Jun 11, 2025

Uh oh!

rust-bors bot commented Jun 11, 2025

Uh oh!

rust-bors bot commented Jun 11, 2025

Uh oh!

Qelxiros commented Jun 11, 2025

Uh oh!

rust-bors bot commented Jun 11, 2025

Uh oh!

tgross35 commented Jun 11, 2025

Uh oh!

rust-bors bot commented Jun 11, 2025

Uh oh!

rust-bors bot commented Jun 11, 2025

Uh oh!

Qelxiros commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Qelxiros commented Jun 20, 2025

Uh oh!

the8472 commented Jun 21, 2025

Uh oh!

rust-bors bot commented Jun 21, 2025

Uh oh!

rust-bors bot commented Jun 21, 2025

Uh oh!

Uh oh!

Qelxiros commented Apr 8, 2025 •

edited by rustbot

Loading