-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[DO NOT MERGE] build Enzyme as archive #140799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
This comment has been minimized.
This comment has been minimized.
@bors try |
[DO NOT MERGE] build Enzyme as archive r? ghost try-job: dist-aarch64-apple
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@Kobzol this is the PR about which I asked you. The error shows up in all cases, no matter whether we build Enzyme and/or LLVM as static or dynamic. In https://github.com/rust-lang/rust/pull/140799/files#diff-5a1e05f2688d271039171a547d407d0c8a96715ee64d35562fc76b4c9a874303 we link against Enzyme inside of That could be checked in I think in general I'm just confused by bootstrap and how we should fix it. Bjorn or you said Backends can be dlopen'ed and thus swapped at rustc runtime. So if we link Enzyme statically, we should only do that once when building rustc for the first time. When building it dynamically we should do it every time, and thus tell rustc where to find it, even when building cranelift, right? Any suggestions on how to handle this? Preferably I would get libEnzyme.so to work (since the artifact can be re-used by downstream users), but either approach is fine to get started. I am also confused by the fact that my rust code first adds
|
This comment has been minimized.
This comment has been minimized.
@bors try |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
|
@bors try |
[DO NOT MERGE] build Enzyme as archive r? ghost try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
[DO NOT MERGE] build Enzyme as archive r? ghost try-job: dist-x86_64-linux
☀️ Try build successful - checks-actions |
@rust-timer build d6d2593 |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (d6d2593): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.1%, secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 5.8%, secondary 3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 689.033s -> 688.949s (-0.01%) |
r? ghost
try-job: dist-x86_64-linux