Skip to content

tests/ui: A New Order [13/N] #142429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests/ui: A New Order [13/N] #142429

wants to merge 1 commit into from
+157 −98

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 12, 2025 •
edited by jieyouxu
Loading

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @jieyouxu

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 12, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 24, 2025

☔ The latest upstream changes (presumably #142956) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

There are changes to the tidy tool.

cc @jieyouxu

jieyouxu
jieyouxu requested changes Jun 28, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits, and then can you squash or otherwise split into the {move, edits} commits for better git history as discussed elsewhere.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2025
jieyouxu
jieyouxu reviewed Jun 29, 2025
View reviewed changes
@jieyouxu
Copy link
Member

One nit on error annotation "lookalikes"
@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 29, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 29, 2025 •
edited
Loading

Also are you still working on compiletest? Because original tracking issue seems like wasn't updated for a long time

Upd: nvm it was updated 5 days ago

@jieyouxu
Copy link
Member

Also are you still working on compiletest? Because original tracking issue seems like wasn't updated for a long time

Yes. If you mean all the implementation PRs, then I also clarified on the PR listing

Note: these are some of the earlier PRs (so not necessarily exhaustive), I may stop updating this listing if we have more PRs.

Because there's quite a few of them.

jieyouxu
jieyouxu reviewed Jun 29, 2025
View reviewed changes
@jieyouxu
Copy link
Member

Thanks, r=me once PR CI is green.
@bors delegate+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

✌️ @Kivooeo, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 29, 2025

@bors r=@jieyouxu

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

📌 Commit d0bd279 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 29, 2025
@GuillaumeGomez
Rollup merge of rust-lang#142429 - Kivooeo:tf13, r=jieyouxu
c5836ec 
`tests/ui`: A New Order [13/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 29, 2025
Closed
bors added a commit that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143211 - GuillaumeGomez:rollup-ug242zk, r=GuillaumeGomez
012c38d 
Rollup of 7 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #143066 (Use let chains in the new solver)
 - #143156 (inherit `#[align]` from trait method prototypes)
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kivooeo Kivooeo mentioned this pull request Jun 29, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2025
@matthiaskrgr
Rollup merge of rust-lang#142429 - Kivooeo:tf13, r=jieyouxu
fee616b 
`tests/ui`: A New Order [13/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? ``@jieyouxu``
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2025
Closed
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143225 - matthiaskrgr:rollup-v6ynl5f, r=matthiaskrgr
3a6a679 
Rollup of 7 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #143066 (Use let chains in the new solver)
 - #143156 (inherit `#[align]` from trait method prototypes)
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
dianqk added a commit to dianqk/rust that referenced this pull request Jun 30, 2025
@dianqk
Rollup merge of rust-lang#142429 - Kivooeo:tf13, r=jieyouxu
384d699 
`tests/ui`: A New Order [13/N]

Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

r? ```@jieyouxu```
@dianqk dianqk mentioned this pull request Jun 30, 2025
Open
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
c65dcca 
Rollup of 14 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - #143066 (Use let chains in the new solver)
 - #143090 (Workaround for memory unsafety in third party DLLs)
 - #143118 (`tests/ui`: A New Order [15/N])
 - #143159 (Do not freshen `ReError`)
 - #143168 (`tests/ui`: A New Order [16/N])
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - #143195 (`tests/ui`: A New Order [17/N])
 - #143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@jieyouxu jieyouxu

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kivooeo @rust-log-analyzer @bors @rustbot @jieyouxu