Fix random failure when JS code is executed when the whole file was not read yet

[GuillaumeGomez]

Very randomly (and rarely), when I arrived on a page with ?search=something in the URL, I got this error:

Moving the initSearch function at the bottom to ensure everything has been loaded fixes the issue.

PS: Sorry for the noise. Pushed to the wrong branch and #142496 closed. ><

[rustbot]

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

[lolbinarycat]

isn't it only the invitation of initSearch that needs to be moved to the bottom, not the definition? i guess both can be moved just for the sake of readability, but in either case, there should be a comment saying how nothing else should happen after initSearch is called (ideally we could make tidy ensure this, but i don't think they're a handy directive for "nothing except closing blocks past this point")

[GuillaumeGomez]

Indeed but since the function was called right after being created, I just kept them together for coherency with current code.

[lolbinarycat]

I do still believe there should be some comment at the bottom of the file saying how new code must be added before the call to initSearch to avoid a race condition.

[GuillaumeGomez]

Very good point, adding it.

[lolbinarycat]

technically the comment should go after the definition of initSearch or before the call to registerSearchEvents, but i guess this is maybe ok..?

[GuillaumeGomez]

If the comment is just just after initSearch call, it makes it easier to miss the part where your code is supposed to be before it imo.

[lolbinarycat]

I'm actually running into this when trying to debug PRs, and it seems like a trivial fix, so I think it makes sense to move forward with this.