nicer autodiff error handling #142842
Open
nicer autodiff error handling #142842
+73
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa |
|
Please give the commit a proper commit message 😆 |
ZuseZ4
force-pushed
the
autodiff-error-handling
branch
from
acde7fc to
f21fac3
Compare
|
cc @Sa4dUs that should prevent your issue in the future. |
ZuseZ4
force-pushed
the
autodiff-error-handling
branch
from
f21fac3 to
5c4b6cc
Compare
|
ok, I'm happy with these two tests, let me know if you want any changes. |
ZuseZ4
force-pushed
the
autodiff-error-handling
branch
from
5c4b6cc to
3610d7c
Compare
oli-obk
reviewed
Jun 27, 2025
| @@ -419,7 +419,12 @@ fn generate_lto_work<B: ExtraBackendMethods>( | |||
| } else { | |||
| if !autodiff.is_empty() { | |||
There was a problem hiding this comment.
maybe pick a random (like the first) entry from this list and use its span so in case of a larger crate the user is aware of why this is being emitted. I could see it being confusing in case someone is adding cfgs to turn on/off autodiff and got sth wrong in the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still intend to finish #137570 by adding proper handling for library builds.
I was hoping to directly get the proper fix in, but I haven't had the time in a while, and other contributors and early testers run into this issue often enough.