Skip to content

Update stage0 to 1.89.0-beta.1 #142974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update stage0 to 1.89.0-beta.1 #142974

wants to merge 4 commits into from
+555 −653

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 24, 2025 •
edited by matthiaskrgr
Loading

  • Update version placeholders
  • Update stage0 to 1.89.0-beta.1
  • Update STAGE0_MISSING_TARGETS
  • Update cfg(bootstrap)

r? @Mark-Simulacrum

try-job: dist-i586-gnu-i586-i686-musl

@rustbot rustbot added O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

The Miri subtree was changed

cc @rust-lang/miri

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

☔ The latest upstream changes (presumably #142979) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

📌 Commit 6cacbc7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jun 26, 2025
@samueltardieu
Rollup merge of rust-lang#142974 - cuviper:stage0-bump, r=Mark-Simula…
d0ef5e3 
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`
@samueltardieu samueltardieu mentioned this pull request Jun 26, 2025
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
@compiler-errors
Rollup merge of rust-lang#142974 - cuviper:stage0-bump, r=Mark-Simula…
8d1e320 
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? ``@Mark-Simulacrum``
@compiler-errors compiler-errors mentioned this pull request Jun 27, 2025
Closed
bors added a commit that referenced this pull request Jun 27, 2025
@bors
Auto merge of #143105 - compiler-errors:rollup-68jh88u, r=compiler-er…
b69da27 
…rors

Rollup of 8 pull requests

Successful merges:

 - #139858 (New const traits syntax)
 - #140809 (Reduce special casing for the panic runtime)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143002 (tests: Require `run-fail` ui tests to have an exit code (`SIGABRT` not ok))
 - #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
 - #143096 (tag_for_variant: properly pass TypingEnv)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#142974 - cuviper:stage0-bump, r=Mark-Simula…
5e7a2ad 
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`
This was referenced Jun 28, 2025
Closed
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#142974 - cuviper:stage0-bump, r=Mark-Simula…
ae89e15 
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? ``@Mark-Simulacrum``
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143153 - matthiaskrgr:rollup-9o7vdtp, r=matthiaskrgr
6745297 
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2025
@matthiaskrgr
Copy link
Member

@bors try
wondering if this caused #143153 (comment) somehow

bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #142974 - cuviper:stage0-bump, r=<try>
233101c 
Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`

try-job: dist-i586-gnu-i586-i686-musl
@bors
Copy link
Collaborator

bors commented Jun 28, 2025

⌛ Trying commit 6cacbc7 with merge 233101c...

@ehuss
Copy link
Contributor

ehuss commented Jun 28, 2025 •
edited
Loading

Oh crud, looks like I missed dist-i586-gnu-i586-i686-musl (I didn't check any dist jobs because I assumed they didn't run any tests).

@cuviper I think the solution is to just add ignore-i586 to those tests in

rust/library/core/src/num/f64.rs

Line 973 in 7ba34c7

/// ```ignore-arm-unknown-linux-gnueabihf (see https://github.com/rust-lang/rust/issues/141087)
and

rust/library/core/src/num/f64.rs

Line 946 in 7ba34c7

/// ```ignore-arm-unknown-linux-gnueabihf (see https://github.com/rust-lang/rust/issues/141087)
.

I'm not sure if that is exactly the same underlying problem as #141087. There were some fixes posted in llvm/llvm-project#142170, but I don't know if that helps i586.

@rust-log-analyzer
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test library/core/src/time.rs - time::Duration::saturating_mul (line 769) ... ok

failures:

---- library/core/src/num/f64.rs - f64::f64::maximum (line 946) stdout ----
rustc-LLVM ERROR: Cannot select: 0x7f002c0b8560: i8 = setcc 0x7f002c0bca90, Constant:i64<0>, seteq:ch
  0x7f002c0bca90: i64 = bitcast 0x7f002c0bc940
    0x7f002c0bc940: f64,ch = CopyFromReg 0x7f002c009ba0, Register:f64 %2
      0x7f002c0bc5c0: f64 = Register %2
  0x7f002c0bce10: i64 = Constant<0>
In function: _ZN4core3f6421_$LT$impl$u20$f64$GT$7maximum17h750256185e43a972E
Couldn't compile the test.
---- library/core/src/num/f64.rs - f64::f64::minimum (line 973) stdout ----
rustc-LLVM ERROR: Cannot select: 0x7fbc28050200: i8 = setcc 0x7fbc28056240, Constant:i64<-9223372036854775808>, seteq:ch
  0x7fbc28056240: i64 = bitcast 0x7fbc280565c0
    0x7fbc280565c0: f64,ch = CopyFromReg 0x7fbc28009890, Register:f64 %2
      0x7fbc28056780: f64 = Register %2
  0x7fbc28056d30: i64 = Constant<-9223372036854775808>
In function: _ZN4core3f6421_$LT$impl$u20$f64$GT$7minimum17he24310d68808ff6cE
Couldn't compile the test.

failures:
    library/core/src/num/f64.rs - f64::f64::maximum (line 946)
    library/core/src/num/f64.rs - f64::f64::minimum (line 973)

@bors
Copy link
Collaborator

bors commented Jun 28, 2025

💔 Test failed - checks-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @rustbot @bors @Mark-Simulacrum @matthiaskrgr @ehuss @rust-log-analyzer