Skip to content

Rolling up PRs in the queue #18368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Oct 28, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
cb5593a
Guide: Change >= to > in closure
cakebaker Oct 22, 2014
de06faf
Use local cache when there are unbound type variables and where claus…
nikomatsakis Oct 22, 2014
ebdc304
Fixed single quote around string slice and simplify example
areski Oct 22, 2014
70fe20a
Fix codegen breaking aliasing rules for functions with sret results
dotdash Oct 22, 2014
0c3ad8b
build the crates guide
steveklabnik Oct 23, 2014
941d90d
Add syntax::print::pprint::view_item_to_string
SimonSapin Oct 23, 2014
0b8bd6f
plugin-guide: nicer creation of the parser
globin Oct 23, 2014
398b287
Register new snapshots
alexcrichton Oct 23, 2014
53ac852
Fail immediately if linking returns status code != 0
msiemens Oct 22, 2014
d7e910e
Update .mailmap
Oct 23, 2014
e4b913f
s/vtable2/vtable
nrc Oct 23, 2014
4a8d712
Use type-safe wrapper for TypeFlags
nikomatsakis Oct 24, 2014
87a5f0d
Make the Vec data structure layout match raw::Slice.
Oct 25, 2014
1221999
Guide: Fix off-by-one error
cakebaker Oct 25, 2014
81b7e62
Prevent pointer -> int casts in constexprs
arielb1 Oct 25, 2014
3942ab9
make the core::raw struct representation defined
thestinger Oct 25, 2014
019a982
Guide: drop :d formatting where unnecessary
chastell Oct 25, 2014
6a22454
Guide: Cargo now adds bang and drops the semicolon for ‘Hello, world’
chastell Oct 25, 2014
eb903b4
Guide: update Testing output and fix contents to match
chastell Oct 25, 2014
2c744c7
Add test cases for E-needstest issues
Oct 25, 2014
971d776
Add Span and separate open/close delims to TTDelim
brendanzab Oct 22, 2014
ec3f020
Rename TokenTree variants for clarity
brendanzab Oct 22, 2014
6a50b4d
Prevent some vector reallocations
brendanzab Oct 22, 2014
dfb4163
Use standard capitalisation for TokenTree variants
brendanzab Oct 22, 2014
34dacb8
Reduce the size of the TokenTree
brendanzab Oct 22, 2014
94d6eee
Add a KleeneOp enum for clarity
brendanzab Oct 23, 2014
9acce10
Finish cfg syntax transition
sfackler Oct 25, 2014
6598d33
Update parse::test::string_to_tts_1 test
brendanzab Oct 25, 2014
f29535d
Fix bug #17982.
vadimcn Oct 26, 2014
bed5a7d
Add MemWriter::from_vec
sfackler Oct 26, 2014
3040320
Fix spelling mistakes in comments.
jbcrail Oct 26, 2014
2877e47
Ensure unboxed closure upvars are marked as used mutably
bkoropoff Oct 26, 2014
1062955
Tweak mem categorization of upvar mutability
bkoropoff Oct 26, 2014
7129f17
Improve diagnostics that result from the fix for #18335
bkoropoff Oct 26, 2014
6be48ea
Add regression test for #18238 and #18336
bkoropoff Oct 26, 2014
5662bba
Add regression test for #18335
bkoropoff Oct 26, 2014
79e05e9
Implement Show for `Arc<T>`
aochagavia Oct 26, 2014
622ae41
Guide: Add link to FFI explanation
cakebaker Oct 26, 2014
f16744c
Fix a typecheck regression with constant borrowed pointers in patterns
Oct 26, 2014
d257b37
Guide: motivate Box and Rc pointers with need, uses, benefits, and ex…
Oct 22, 2014
8a4bd84
Added Encodable and Decodable for Arc<T>.
csherratt Oct 26, 2014
e5f7090
Preserve struct field pattern shorthand in the prettyprinter.
kevinmehall Oct 27, 2014
25650e0
Guide: Add missing "a"
cakebaker Oct 27, 2014
b8c4eb3
Fix undefined behavior in std::ascii
aochagavia Oct 27, 2014
9dab887
Show a note when closure field is called as method
aochagavia Oct 26, 2014
2ce77b3
Add test for issue 18343
aochagavia Oct 27, 2014
83e91fb
rollup merge of #18221 : jkleint/guide-boxes
alexcrichton Oct 27, 2014
b3c676e
rollup merge of #18229 : bjz/ttdelim
alexcrichton Oct 27, 2014
da57aa5
rollup merge of #18231 : cakebaker/fix_greater_than_forty_two_closure
alexcrichton Oct 27, 2014
0c756de
rollup merge of #18235 : nikomatsakis/issue-18209
alexcrichton Oct 27, 2014
bb70ce6
rollup merge of #18239 : msiemens/fix-ice-rename-failed
alexcrichton Oct 27, 2014
a6883d4
rollup merge of #18244 : areski/pr-fix-string-doc
alexcrichton Oct 27, 2014
e953773
rollup merge of #18250 : dotdash/fix_aliasing
alexcrichton Oct 27, 2014
6f65ad1
rollup merge of #18251 : steveklabnik/build_module_guide
alexcrichton Oct 27, 2014
2f8ee08
rollup merge of #18256 : SimonSapin/view_item_to_string
alexcrichton Oct 27, 2014
ecdb19c
rollup merge of #18257 : globin/master
alexcrichton Oct 27, 2014
dc5a18c
rollup merge of #18265 : jakub-/mailmap
alexcrichton Oct 27, 2014
dea37d7
rollup merge of #18266 : nick29581/vtable2.rs
alexcrichton Oct 27, 2014
ee32c04
rollup merge of #18303 : cgaebel/make-vec-match-slice
alexcrichton Oct 27, 2014
0c736c7
rollup merge of #18309 : cakebaker/fix_off_by_one
alexcrichton Oct 27, 2014
abfc2f3
rollup merge of #18315 : arielb1/constexpr-addr
alexcrichton Oct 27, 2014
9dc9ecc
rollup merge of #18316 : thestinger/raw
alexcrichton Oct 27, 2014
54647bd
rollup merge of #18320 : chastell/guide_simplify_formatting
alexcrichton Oct 27, 2014
dac3234
rollup merge of #18321 : chastell/guide_refresh_testing_output
alexcrichton Oct 27, 2014
f1118cc
rollup merge of #18324 : jakub-/eneedstest
alexcrichton Oct 27, 2014
650214b
rollup merge of #18326 : sfackler/cfg-final
alexcrichton Oct 27, 2014
ed7f4a8
rollup merge of #18327 : vadimcn/17982
alexcrichton Oct 27, 2014
287df9e
rollup merge of #18329 : sfackler/memwriter-clear
alexcrichton Oct 27, 2014
175d6a7
rollup merge of #18332 : jbcrail/fix-comments
alexcrichton Oct 27, 2014
1cc938a
rollup merge of #18337 : bkoropoff/unboxed-imm-upvar-fixes
alexcrichton Oct 27, 2014
cfeff3e
rollup merge of #18344 : aochagavia/show-arc
alexcrichton Oct 27, 2014
15547e1
rollup merge of #18346 : aochagavia/closure-fields
alexcrichton Oct 27, 2014
a1d719d
rollup merge of #18347 : cakebaker/ffi
alexcrichton Oct 27, 2014
c381752
rollup merge of #18356 : jakub-/const-pattern-suptype
alexcrichton Oct 27, 2014
20b9897
rollup merge of #18362 : kevinmehall/pprint-struct-pat-shorthand
alexcrichton Oct 27, 2014
c5cc27f
rollup merge of #18364 : cakebaker/missing_a
alexcrichton Oct 27, 2014
6e9d5a6
rollup merge of #18366 : aochagavia/ascii
alexcrichton Oct 27, 2014
40811f8
rollup merge of #18334 : csherratt/arc-encodable
alexcrichton Oct 27, 2014
a33d761
Test fixes and rebase conflicts from rollup
alexcrichton Oct 27, 2014
4dc06dc
rollup merge of #18259 : alexcrichton/snapshots
alexcrichton Oct 27, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 98 additions & 2 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,104 @@
# email addresses.
#

Elly Jones <elly@leptoquark.net>
ILyoan <ilyoan@gmail.com>
Aaron Todd <github@opprobrio.us>
Ahmed Charles <ahmedcharles@gmail.com> <acharles@outlook.com>
Alex Lyon <arcterus@mail.com> <Arcterus@mail.com>
Alex Rønne Petersen <alex@lycus.org>
Andreas Gal <gal@mozilla.com> <andreas.gal@gmail.com>
Andrew Poelstra <asp11@sfu.ca> <apoelstra@wpsoftware.net>
Anton Löfgren <anton.lofgren@gmail.com> <alofgren@op5.com>
Ariel Ben-Yehuda <arielb1@mail.tau.ac.il> <ariel.byd@gmail.com>
Austin Seipp <mad.one@gmail.com> <as@hacks.yi.org>
Ben Alpert <ben@benalpert.com> <spicyjalapeno@gmail.com>
Benjamin Jackman <ben@jackman.biz>
Björn Steinbrink <bsteinbr@gmail.com> <B.Steinbrink@gmx.de>
blake2-ppc <ulrik.sverdrup@gmail.com> <blake2-ppc>
Boris Egorov <jightuse@gmail.com> <egorov@linux.com>
Brian Anderson <banderson@mozilla.com> <andersrb@gmail.com>
Brian Dawn <brian.t.dawn@gmail.com>
Carl-Anton Ingmarsson <mail@carlanton.se> <ca.ingmarsson@gmail.com>
Carol Willing <carolcode@willingconsulting.com>
Chris Pressey <cpressey@gmail.com>
Clark Gaebel <cg.wowus.cg@gmail.com> <cgaebel@mozilla.com>
David Klein <david.klein@baesystemsdetica.com>
David Manescu <david.manescu@gmail.com> <dman2626@uni.sydney.edu.au>
Damien Schoof <damien.schoof@gmail.com>
Derek Chiang <derekchiang93@gmail.com> Derek Chiang (Enchi Jiang) <derekchiang93@gmail.com>
Dylan Braithwaite <dylanbraithwaite1@gmail.com> <mail@dylanb.me>
Eduardo Bautista <me@eduardobautista.com> <mail@eduardobautista.com>
Eduardo Bautista <me@eduardobautista.com> <=>
Elliott Slaughter <elliottslaughter@gmail.com> <eslaughter@mozilla.com>
Elly Fong-Jones <elly@leptoquark.net>
Eric Holk <eric.holk@gmail.com> <eholk@mozilla.com>
Eric Holk <eric.holk@gmail.com> <eholk@cs.indiana.edu>
Eric Holmes <eric@ejholmes.net>
Eric Reed <ecreed@cs.washington.edu> <ereed@mozilla.com>
Erick Tryzelaar <erick.tryzelaar@gmail.com> <etryzelaar@iqt.org>
Evgeny Sologubov
Falco Hirschenberger <falco.hirschenberger@gmail.com> <hirschen@itwm.fhg.de>
Gareth Daniel Smith <garethdanielsmith@gmail.com>
Georges Dubus <georges.dubus@gmail.com> <georges.dubus@compiletoi.net>
Graham Fawcett <fawcett@uwindsor.ca> <graham.fawcett@gmail.com>
Graydon Hoare <graydon@mozilla.com> <graydon@pobox.com>
Heather <heather@cynede.net> <Heather@cynede.net>
Heather <heather@cynede.net> <Cynede@Gentoo.org>
Ilyong Cho <ilyoan@gmail.com>
J. J. Weber <jjweber@gmail.com>
Jakub Bukaj <jakub@jakub.cc>
Jakub Bukaj <jakub@jakub.cc> <jakubw@jakubw.net>
James Deng <cnjamesdeng@gmail.com> <cnJamesDeng@gmail.com>
James Miller <bladeon@gmail.com> <james@aatch.net>
Jason Orendorff <jorendorff@mozilla.com> <jason@mozmac-2.local>
Jason Orendorff <jorendorff@mozilla.com> <jason.orendorff@gmail.com>
Jeremy Letang <letang.jeremy@gmail.com>
Jihyun Yu <jihyun@nclab.kaist.ac.kr> jihyun <jihyun@nablecomm.com>
Jihyun Yu <jihyun@nclab.kaist.ac.kr> <yjh0502@gmail.com>
John Clements <clements@racket-lang.org> <clements@brinckerhoff.org>
Jorge Aparicio <japaric@linux.com> <japaricious@gmail.com>
Jonathan Bailey <jbailey@mozilla.com> <jbailey@jbailey-20809.local>
Junyoung Cho <june0.cho@samsung.com>
Jyun-Yan You <jyyou.tw@gmail.com> <jyyou@cs.nctu.edu.tw>
Kang Seonghoon <kang.seonghoon@mearie.org> <public+git@mearie.org>
Keegan McAllister <kmcallister@mozilla.com> <mcallister.keegan@gmail.com>
Kyeongwoon Lee <kyeongwoon.lee@samsung.com>
Lee Wondong <wdlee91@gmail.com>
Lennart Kudling <github@kudling.de>
Lindsey Kuper <lindsey@composition.al> <lindsey@rockstargirl.org>
Lindsey Kuper <lindsey@composition.al> <lkuper@mozilla.com>
Luqman Aden <me@luqman.ca> <laden@mozilla.com>
Luqman Aden <me@luqman.ca> <laden@csclub.uwaterloo.ca>
Luke Metz <luke.metz@students.olin.edu>
Makoto Nakashima <makoto.nksm+github@gmail.com> <makoto.nksm@gmail.com>
Makoto Nakashima <makoto.nksm+github@gmail.com> gifnksm <makoto.nksm+github@gmail.com>
Margaret Meyerhofer <mmeyerho@andrew.cmu.edu> <mmeyerho@andrew>
Mark Sinclair <mark.edward.x@gmail.com>
Mark Sinclair <mark.edward.x@gmail.com> =Mark Sinclair <=125axel125@gmail.com>
Matt Brubeck <mbrubeck@limpet.net> <mbrubeck@cs.hmc.edu>
Matthew Auld <matthew.auld@intel.com>
Matthew McPherrin <matthew@mcpherrin.ca> <matt@mcpherrin.ca>
Matthijs Hofstra <thiezz@gmail.com>
Michael Williams <m.t.williams@live.com>
Michael Woerister <michaelwoerister@gmail> <michaelwoerister@gmail.com>
Michael Woerister <michaelwoerister@gmail> <michaelwoerister@posteo>
Neil Pankey <npankey@gmail.com> <neil@wire.im>
Philipp Brüschweiler <blei42@gmail.com> <blei42@gmail.com>
Philipp Brüschweiler <blei42@gmail.com> <bruphili@student.ethz.ch>
Pradeep Kumar <gohanpra@gmail.com>
Richard Diamond <wichard@vitalitystudios.com> <wichard@hahbee.co>
Rob Arnold <robarnold@cs.cmu.edu>
Robert Gawdzik <rgawdzik@hotmail.com> Robert Gawdzik ☢ <rgawdzik@hotmail.com>
Robert Millar <robert.millar@cantab.net>
Ryan Scheel <ryan.havvy@gmail.com>
Seonghyun Kim <sh8281.kim@samsung.com>
Simon Barber-Dueck <sbarberdueck@gmail.com> Simon BD <simon@server>
Simon Sapin <simon@exyr.org> <simon.sapin@exyr.org>
startling <tdixon51793@gmail.com>
Steven Fackler <sfackler@gmail.com> <sfackler@palantir.com>
Steven Stewart-Gallus <sstewartgallus00@langara.bc.ca> <sstewartgallus00@mylangara.bc.ca>
Tim Chevalier <chevalier@alum.wellesley.edu> <catamorphism@gmail.com>
Torsten Weber <TorstenWeber12@gmail.com> <torstenweber12@gmail.com>
William Ting <io@williamting.com> <william.h.ting@gmail.com>
Youngsoo Son <ysson83@gmail.com> <ysoo.son@samsung.com>
Zack Corr <zack@z0w0.me> <zackcorr95@gmail.com>
Zack Slayton <zack.slayton@gmail.com>
1 change: 1 addition & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,7 @@ do
make_dir $h/test/doc-guide-container
make_dir $h/test/doc-guide-tasks
make_dir $h/test/doc-guide-plugin
make_dir $h/test/doc-guide-crates
make_dir $h/test/doc-rust
done

Expand Down
2 changes: 1 addition & 1 deletion mk/docs.mk
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
######################################################################
DOCS := index intro tutorial guide guide-ffi guide-macros guide-lifetimes \
guide-tasks guide-container guide-pointers guide-testing \
guide-plugin complement-bugreport \
guide-plugin guide-crates complement-bugreport \
complement-lang-faq complement-design-faq complement-project-faq rust \
rustdoc guide-unsafe guide-strings reference

Expand Down
2 changes: 1 addition & 1 deletion src/doc/guide-crates.md
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ fn main() {

Rust will give us a compile-time error:

```{rust,ignore}
```{notrust,ignore}
Compiling phrases v0.0.1 (file:///home/you/projects/phrases)
/home/you/projects/phrases/src/main.rs:4:5: 4:40 error: a value named `hello` has already been imported in this module
/home/you/projects/phrases/src/main.rs:4 use phrases::japanese::greetings::hello;
Expand Down
7 changes: 3 additions & 4 deletions src/doc/guide-plugin.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ extern crate rustc;

use syntax::codemap::Span;
use syntax::parse::token::{IDENT, get_ident};
use syntax::ast::{TokenTree, TTTok};
use syntax::ast::{TokenTree, TtToken};
use syntax::ext::base::{ExtCtxt, MacResult, DummyResult, MacExpr};
use syntax::ext::build::AstBuilder; // trait for expr_uint
use rustc::plugin::Registry;
Expand All @@ -71,7 +71,7 @@ fn expand_rn(cx: &mut ExtCtxt, sp: Span, args: &[TokenTree])
("I", 1)];

let text = match args {
[TTTok(_, IDENT(s, _))] => get_ident(s).to_string(),
[TtToken(_, IDENT(s, _))] => get_ident(s).to_string(),
_ => {
cx.span_err(sp, "argument should be a single identifier");
return DummyResult::any(sp);
Expand Down Expand Up @@ -151,8 +151,7 @@ higher-level syntax elements like expressions:
fn expand_foo(cx: &mut ExtCtxt, sp: Span, args: &[TokenTree])
-> Box<MacResult+'static> {

let mut parser =
parse::new_parser_from_tts(cx.parse_sess(), cx.cfg(), args.to_slice())
let mut parser = cx.new_parser_from_tts(args);

let expr: P<Expr> = parser.parse_expr();
```
Expand Down
2 changes: 1 addition & 1 deletion src/doc/guide-pointers.md
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ great detail, so if you want the full details, check that out.

In general, prefer stack allocation over heap allocation. Using references to
stack allocated information is preferred whenever possible. Therefore,
references are the default pointer type you should use, unless you have
references are the default pointer type you should use, unless you have a
specific reason to use a different type. The other types of pointers cover when
they're appropriate to use in their own best practices sections.

Expand Down
12 changes: 6 additions & 6 deletions src/doc/guide-strings.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Rust has two main types of strings: `&str` and `String`.

# &str

The first kind is a `&str`. This is pronounced a 'string slice.' String literals
are of the type `&str`:
The first kind is a `&str`. This is pronounced a 'string slice'.
String literals are of the type `&str`:

```{rust}
let string = "Hello there.";
Expand Down Expand Up @@ -121,8 +121,8 @@ Both of these lines will print `12`.
To compare a String to a constant string, prefer `as_slice()`...

```{rust}
fn compare(string: String) {
if string.as_slice() == "Hello" {
fn compare(x: String) {
if x.as_slice() == "Hello" {
println!("yes");
}
}
Expand All @@ -131,8 +131,8 @@ fn compare(string: String) {
... over `to_string()`:

```{rust}
fn compare(string: String) {
if string == "Hello".to_string() {
fn compare(x: String) {
if x == "Hello".to_string() {
println!("yes");
}
}
Expand Down
Loading