Skip to content

Add JSON parser rule for custom_unwind_resume. #29471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pierzchalski
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Is there a reason for including this beyond completeness? The field is basically "extra unstable" and I'm curious if it's actually needed anywhere else.

@pierzchalski
Copy link
Contributor Author

cargo rustc doesn't pass extra flags transitively to dependencies, so being able to emulate -Z no-landing-pads using the platform description - even in a round-about way - comes in handy.

@alexcrichton
Copy link
Member

@bors: r+ 054e409

bors added a commit that referenced this pull request Nov 1, 2015
@bors
Copy link
Collaborator

bors commented Nov 1, 2015

⌛ Testing commit 054e409 with merge af6e413...

@bors bors merged commit 054e409 into rust-lang:master Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants