-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Rewrite variadic-ffi pass to use test helper #33894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite variadic-ffi pass to use test helper #33894
Conversation
The sprintf used in this test previously isn’t available on some versions of MSVC. Fixes rust-lang#32305
⌛ Testing commit f181187 with merge c722edb... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors retry |
I'd just like to take a moment to point out that there is actually in fact a printf you can link to. |
⌛ Testing commit f181187 with merge f83a52f... |
💔 Test failed - auto-linux-64-cross-netbsd |
@bors: retry On Sun, May 29, 2016 at 8:17 PM, bors notifications@github.com wrote:
|
⌛ Testing commit f181187 with merge 25b8b14... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
We've had a lot of flaky tests recently, but that one actually looks legit |
Yep, already discussed it with @nagisa on IRC, an |
@bors r=alexcrichton 6bf633a |
92e7535
to
6bf633a
Compare
🙀 |
⌛ Testing commit 6bf633a with merge c3a43b2... |
💔 Test failed - auto-mac-64-opt |
Hopefully this pacifies the 32bit windows. Apparently there’s an ABI out there that not only allows non-64 bit variadic arguments, but also has differing ABI for them! Good thing all variadic functions are unsafe.
6bf633a
to
ed4688c
Compare
@bors r=alexcrichton ed4688c |
⌛ Testing commit ed4688c with merge 915b003... |
…excrichton Rewrite variadic-ffi pass to use test helper The sprintf used in this test previously isn’t available on some versions of MSVC. Fixes #32305 r? @alexcrichton
The sprintf used in this test previously isn’t available on some versions of MSVC.
Fixes #32305
r? @alexcrichton