Skip to content

Rewrite variadic-ffi pass to use test helper #33894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2016

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented May 27, 2016

The sprintf used in this test previously isn’t available on some versions of MSVC.

Fixes #32305

r? @alexcrichton

The sprintf used in this test previously isn’t available on some versions of MSVC.

Fixes rust-lang#32305
@alexcrichton
Copy link
Member

@bors: r+ f181187

@bors
Copy link
Collaborator

bors commented May 29, 2016

⌛ Testing commit f181187 with merge c722edb...

@bors
Copy link
Collaborator

bors commented May 29, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@eddyb
Copy link
Member

eddyb commented May 29, 2016

@bors retry

@retep998
Copy link
Member

I'd just like to take a moment to point out that there is actually in fact a printf you can link to. legacy_stdio_definitions.lib which is only available when you're using a new enough msvc to not have printf otherwise.

@bors
Copy link
Collaborator

bors commented May 30, 2016

⌛ Testing commit f181187 with merge f83a52f...

@bors
Copy link
Collaborator

bors commented May 30, 2016

💔 Test failed - auto-linux-64-cross-netbsd

@alexcrichton
Copy link
Member

@bors: retry

On Sun, May 29, 2016 at 8:17 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cross-netbsd
http://buildbot.rust-lang.org/builders/auto-linux-64-cross-netbsd/builds/443


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#33894 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95OtYSc87IyJyIddJ6XtnQXRxQMbCks5qGlbDgaJpZM4IoEJA
.

@bors
Copy link
Collaborator

bors commented May 31, 2016

⌛ Testing commit f181187 with merge 25b8b14...

@bors
Copy link
Collaborator

bors commented May 31, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

We've had a lot of flaky tests recently, but that one actually looks legit

@retep998
Copy link
Member

Yep, already discussed it with @nagisa on IRC, an i32 is being passed to the variadic function where it actually expects an int64_t, which does matter for the 32-bit calling convention, thus causing UB.

@nagisa
Copy link
Member Author

nagisa commented Jun 2, 2016

@bors r=alexcrichton 6bf633a

@nagisa nagisa force-pushed the windows-lack-endurance-for-sprint branch 2 times, most recently from 92e7535 to 6bf633a Compare June 2, 2016 14:23
@bors
Copy link
Collaborator

bors commented Jun 2, 2016

🙀 92e7535 is not a valid commit SHA. Please try again with 6bf633a.

@bors
Copy link
Collaborator

bors commented Jun 2, 2016

⌛ Testing commit 6bf633a with merge c3a43b2...

@bors
Copy link
Collaborator

bors commented Jun 2, 2016

💔 Test failed - auto-mac-64-opt

Hopefully this pacifies the 32bit windows. Apparently there’s an ABI out there that not only allows
non-64 bit variadic arguments, but also has differing ABI for them!

Good thing all variadic functions are unsafe.
@nagisa nagisa force-pushed the windows-lack-endurance-for-sprint branch from 6bf633a to ed4688c Compare June 2, 2016 17:10
@nagisa
Copy link
Member Author

nagisa commented Jun 2, 2016

@bors r=alexcrichton ed4688c

@bors
Copy link
Collaborator

bors commented Jun 2, 2016

⌛ Testing commit ed4688c with merge 915b003...

bors added a commit that referenced this pull request Jun 2, 2016
…excrichton

Rewrite variadic-ffi pass to use test helper

The sprintf used in this test previously isn’t available on some versions of MSVC.

Fixes #32305

r? @alexcrichton
@bors bors merged commit ed4688c into rust-lang:master Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants