Skip to content

light warning cleanup #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/libextra/arc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,13 @@ pub impl<T:Owned> MutexARC<T> {
*/
#[inline(always)]
unsafe fn access<U>(&self, blk: &fn(x: &mut T) -> U) -> U {
unsafe {
let state = self.x.get();
// Borrowck would complain about this if the function were
// not already unsafe. See borrow_rwlock, far below.
do (&(*state).lock).lock {
check_poison(true, (*state).failed);
let _z = PoisonOnFail(&mut (*state).failed);
blk(&mut (*state).data)
}
let state = self.x.get();
// Borrowck would complain about this if the function were
// not already unsafe. See borrow_rwlock, far below.
do (&(*state).lock).lock {
check_poison(true, (*state).failed);
let _z = PoisonOnFail(&mut (*state).failed);
blk(&mut (*state).data)
}
}

Expand Down
1 change: 0 additions & 1 deletion src/libextra/bitv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use core::prelude::*;
use core::cmp;
use core::ops;
use core::uint;
use core::vec::from_elem;
use core::vec;

struct SmallBitv {
Expand Down
2 changes: 0 additions & 2 deletions src/libextra/flate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Simple compression

#[allow(missing_doc)];

use core::prelude::*;

use core::libc::{c_void, size_t, c_int};
use core::libc;
use core::vec;
Expand Down
1 change: 1 addition & 0 deletions src/libextra/std.rc
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ not required in or otherwise suitable for the core library.

extern mod core(name = "std", vers = "0.7-pre");

#[cfg(stage0)]
use core::{str, unstable};
use core::str::{StrSlice, OwnedStr};

Expand Down
2 changes: 0 additions & 2 deletions src/libextra/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ use term;
use core::comm::{stream, SharedChan};
use core::either;
use core::io;
use core::num;
use core::option;
use core::result;
use core::str;
use core::task;
use core::to_str::ToStr;
use core::u64;
use core::uint;
use core::vec;

Expand Down
2 changes: 0 additions & 2 deletions src/libextra/uv_global_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ use iotask = uv_iotask;
use uv_iotask::{IoTask, spawn_iotask};

use core::comm::Chan;
use core::libc;
use core::option::{Some, None};
use core::str;
use core::task::task;
use core::unstable::global::{global_data_clone_create, global_data_clone};
use core::unstable::weak_task::weaken_task;
Expand Down
2 changes: 0 additions & 2 deletions src/librustc/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,7 @@ pub mod jit {
use metadata::cstore;

use core::cast;
use core::char;
use core::libc::c_int;
use core::os;
use core::ptr;
use core::str;

Expand Down
2 changes: 1 addition & 1 deletion src/librustc/back/passes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use core::prelude::*;
use core::str;
use core::io;

use driver::session::{OptLevel, No, Less, Default, Aggressive};
use driver::session::{OptLevel, No, Less, Aggressive};
use driver::session::{Session};
use lib::llvm::{PassRef, ModuleRef,PassManagerRef,TargetDataRef};
use lib::llvm::llvm;
Expand Down
1 change: 0 additions & 1 deletion src/librustc/middle/trans/foreign.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ use middle::ty;
use middle::ty::FnSig;
use util::ppaux::ty_to_str;

use core::str;
use core::uint;
use core::vec;
use syntax::codemap::span;
Expand Down
1 change: 0 additions & 1 deletion src/librustc/middle/trans/glue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use back::link::*;
use driver::session;
use lib;
use lib::llvm::{llvm, ValueRef, TypeRef, True};
use lib::llvm::type_to_str;
use middle::trans::adt;
use middle::trans::base::*;
use middle::trans::callee;
Expand Down
1 change: 0 additions & 1 deletion src/librustc/middle/ty.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use core::to_bytes;
use core::u32;
use core::uint;
use core::vec;
use extra::smallintmap::SmallIntMap;
use syntax::ast::*;
use syntax::ast_util::is_local;
use syntax::ast_util;
Expand Down
1 change: 1 addition & 0 deletions src/librustc/rustc.rc
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ use middle::lint;
use core::io;
use core::os;
use core::result;
#[cfg(not(stage0))]
use core::str;
use core::task;
use core::uint;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/cell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
//! A mutable, nullable memory location

use cast::transmute_mut;
use cmp;
use prelude::*;
use util::replace;

Expand Down
1 change: 0 additions & 1 deletion src/libstd/iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ implementing the `Iterator` trait.
use cmp;
use iter;
use num::{Zero, One};
use num;
use prelude::*;

/// An interface for dealing with "external iterators". These types of iterators
Expand Down
1 change: 0 additions & 1 deletion src/libstd/local_data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ magic.
use prelude::*;

use task::local_data_priv::{local_get, local_pop, local_modify, local_set, Handle};
use task;

/**
* Indexes a task-local data slot. The function's code pointer is used for
Expand Down
1 change: 0 additions & 1 deletion src/libstd/rand/distributions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
// could implement VIZIGNOR the ZIGNOR paper for more speed.

use f64;
use prelude::*;
use rand::{Rng,Rand};

mod ziggurat_tables;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/rt/task.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ use prelude::*;
use rt::local::Local;
use rt::logging::StdErrLogger;
use super::local_heap::LocalHeap;
use super::sched::Scheduler;

pub struct Task {
heap: LocalHeap,
Expand Down
4 changes: 0 additions & 4 deletions src/libstd/task/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,13 @@

use prelude::*;

use cast;
use cell::Cell;
use cmp::Eq;
use comm::{stream, Chan, GenericChan, GenericPort, Port};
use comm;
use ptr;
use result::Result;
use result;
use rt::{context, OldTaskContext};
use task::rt::{task_id, sched_id};
use task;
use unstable::finally::Finally;
use util::replace;
use util;
Expand Down
2 changes: 0 additions & 2 deletions src/libstd/task/spawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ use cast;
use cell::Cell;
use container::Map;
use comm::{Chan, GenericChan};
use comm;
use ptr;
use hashmap::HashSet;
use task::local_data_priv::{local_get, local_set, OldHandle};
Expand All @@ -89,7 +88,6 @@ use task::{Failure, ManualThreads, PlatformThread, SchedOpts, SingleThreaded};
use task::{Success, TaskOpts, TaskResult, ThreadPerCore, ThreadPerTask};
use task::{ExistingScheduler, SchedulerHandle};
use task::unkillable;
use task;
use uint;
use util;
use unstable::sync::{Exclusive, exclusive};
Expand Down
2 changes: 0 additions & 2 deletions src/libstd/trie.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

//! An ordered map and set for integer keys implemented as a radix trie

use local_data;
use os;
use prelude::*;
use uint;
use util::{swap, replace};
Expand Down
1 change: 0 additions & 1 deletion src/libstd/unstable/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ use comm::{GenericChan, GenericPort};
use comm;
use libc;
use prelude::*;
use ptr;
use task;

pub mod at_exit;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
//! Miscellaneous helpers for common patterns.

use cast;
use local_data;
use ptr;
use prelude::*;
use unstable::intrinsics;
Expand Down
1 change: 0 additions & 1 deletion src/libsyntax/ext/pipes/ast_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use ast::ident;
use ast;
use codemap::span;

use core::str;
use core::vec;

// Transitional reexports so qquote can find the paths it is looking for
Expand Down
1 change: 0 additions & 1 deletion src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ use parse::{new_sub_parser_from_file, next_node_id, ParseSess};
use opt_vec;
use opt_vec::OptVec;

use core::char;
use core::either::Either;
use core::either;
use core::hashmap::HashSet;
Expand Down
2 changes: 0 additions & 2 deletions src/libsyntax/parse/token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ use util::interner;
use core::cast;
use core::char;
use core::cmp::Equiv;
use core::hashmap::HashSet;
use core::local_data;
use core::str;
use core::to_bytes;
use core::vec;

#[deriving(Encodable, Decodable, Eq)]
pub enum binop {
Expand Down