Skip to content

bump jobserver dependency #84407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

bump jobserver dependency #84407

merged 1 commit into from
Apr 22, 2021

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Apr 21, 2021

the newest jobserver version should slightly reduce context switches
in highly parallel build environments on linux kernels >= 5.6

the newest jobserver version should slightly reduce context switches
in highly parallel build environments on linux kernels >= 5.6
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2021
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2021
@bors
Copy link
Collaborator

bors commented Apr 21, 2021

⌛ Trying commit 7f45cdb with merge 25c7c6d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2021
bump jobserver dependency

the newest jobserver version should slightly reduce context switches
in highly parallel build environments on linux kernels >= 5.6
@Mark-Simulacrum
Copy link
Member

The perf server currently has a 4.15 kernel, so this won't obviously see results there, but hopefully also does not show a regression; the perf server should have no real parallelism competition (as the measurements are either done in -j1 or with a single rustc).

@bors
Copy link
Collaborator

bors commented Apr 21, 2021

☀️ Try build successful - checks-actions
Build commit: 25c7c6d (25c7c6d87b2b90db60f22ee377076fb16556f5ee)

@rust-timer
Copy link
Collaborator

Queued 25c7c6d with parent b849326, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (25c7c6d): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2021
@Mark-Simulacrum
Copy link
Member

Looks entirely neutral, as expected; once this lands we may try to get some local testing on a larger machine (I know @joshtriplett had access at one point), but ultimately it's likely not necessary. @bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2021

📌 Commit 7f45cdb has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2021
@bors
Copy link
Collaborator

bors commented Apr 22, 2021

⌛ Testing commit 7f45cdb with merge c757729...

@bors
Copy link
Collaborator

bors commented Apr 22, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing c757729 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2021
@bors bors merged commit c757729 into rust-lang:master Apr 22, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants