-
Notifications
You must be signed in to change notification settings - Fork 13.5k
bump jobserver dependency #84407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump jobserver dependency #84407
Conversation
the newest jobserver version should slightly reduce context switches in highly parallel build environments on linux kernels >= 5.6
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bump jobserver dependency the newest jobserver version should slightly reduce context switches in highly parallel build environments on linux kernels >= 5.6
The perf server currently has a 4.15 kernel, so this won't obviously see results there, but hopefully also does not show a regression; the perf server should have no real parallelism competition (as the measurements are either done in -j1 or with a single rustc). |
☀️ Try build successful - checks-actions |
Queued 25c7c6d with parent b849326, future comparison URL. |
Finished benchmarking try commit (25c7c6d): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Looks entirely neutral, as expected; once this lands we may try to get some local testing on a larger machine (I know @joshtriplett had access at one point), but ultimately it's likely not necessary. @bors r+ |
📌 Commit 7f45cdb has been approved by |
☀️ Test successful - checks-actions |
the newest jobserver version should slightly reduce context switches
in highly parallel build environments on linux kernels >= 5.6