Improve iterator for files suppression #416
Conversation
Liewyec
force-pushed
the
feature/improve-iterator-for-file-suppression
branch
2 times, most recently
from
772f0ef to
0cb2478
Compare
Liewyec
changed the title
build_system/src/test.rs
Outdated
| .enumerate() | ||
| .filter(|(pos, _)| *pos < start || *pos >= end) | ||
| .take(start) | ||
| .skip(count) | ||
| .map(|(_, path)| path) |
There was a problem hiding this comment.
files.iter().take(start).skip(count)you don't need enumerate and map anymore.
There was a problem hiding this comment.
I asked in the issue, but let repeat it here: I do not think this can be done with skip and take, because the filter if I understand it correctly yields items from beginning of the files, skips some in the middle and then possibly yields additional items from end. And I do not know how to do this with take and skip.
There was a problem hiding this comment.
I believe the original code might be wrong. You probably want .skip(start).take(count), though.
The code is supposed to take contiguous elements: that's why I think it might be wrong. Please use .skip(start).take(count) and I'll check if this is OK.
There was a problem hiding this comment.
I updated the code.
Liewyec
force-pushed
the
feature/improve-iterator-for-file-suppression
branch
from
0cb2478 to
599492a
Compare
Liewyec
changed the title
| .filter(|(pos, _)| *pos < start || *pos >= end) | ||
| .map(|(_, path)| path) | ||
| { | ||
| for path in files.iter().skip(start).take(count) { |
There was a problem hiding this comment.
Nice, thanks for the improvement!
|
Thanks for your contribution! |
fixes #395