Fixed some clippy warnings. #716
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slienced some bogus clippy warnings in
abi_tests
.This file is meant to be expanded in the future(by adding options needed for CI runs), and clippy is complaing about some of that scafolding code.
The warning
clippy::never_loop
is raised because the command only supports one argument(--help
) which stops argument parsing, and prints a message. So, the loop can only iterate once: by either printing the help, or an error message(for invalid options). This is correct, and the loop is still needed to handle new parameters we will add in the future.clippy::while_let_on_iterator
, on the other hand, warns us that thiswhile
loop could be rewritten as afor
loop. This is true now, because we don't have any parameters with additional arguments. If we want to add a parameter like this:--abi-cafe-config <path>
, we will need to get the path by calling next. This is not possible when using afor
loop.