Skip to content

largeMessage test fails on chrome #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gzm0 opened this issue Nov 25, 2019 · 7 comments · Fixed by #122
Closed

largeMessage test fails on chrome #105

gzm0 opened this issue Nov 25, 2019 · 7 comments · Fixed by #122
Assignees
@gzm0
Labels
bug

Comments

@gzm0
Copy link
Contributor

gzm0 commented Nov 25, 2019

No description provided.

@gzm0 gzm0 added the bug label Nov 25, 2019
@gzm0 gzm0 mentioned this issue Dec 2, 2020
Closed
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 3, 2020 •
edited
Loading

It seems that chrome does not handle messages containing 0x7F 🤷 It seems to alter them somehow. I still need to find out the details.

gzm0 added a commit to gzm0/chrome-webdriver-js-string that referenced this issue Dec 3, 2020
@gzm0
Minimal reproducible example for scala-js/scala-js-env-selenium#105
7633bb1
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 3, 2020

Seems it simply drops these characters. Minimum reproducible example: https://github.com/gzm0/chrome-webdriver-js-string

@gzm0
Copy link
Contributor Author

gzm0 commented Dec 3, 2020

Filed as https://bugs.chromium.org/p/chromedriver/issues/detail?id=3672

@sjrd
Copy link
Member

sjrd commented Dec 3, 2020

Wow, nice investigation!

@sbrunk
Copy link

sbrunk commented Dec 3, 2020

Interesting. Perhaps some INT8/UINT8 issues then.

@gzm0
Copy link
Contributor Author

gzm0 commented Dec 4, 2020

So just FTR: My preference would be to have this issue solved on the chromedriver end. If necessary, we can work around it by encoding things differently when passing them back from the browser (this workaround would affect all browser types though).

There is currently no workaround that can be applied by users only.

@sbrunk
Copy link

sbrunk commented Dec 7, 2020

I've switched the tests causing #119 to Firefox which is working fine. So I guess we can wait until this is fixed in chromedriver.

@gzm0 gzm0 self-assigned this Dec 14, 2020
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Mar 15, 2021
@gzm0
Fix scala-js#105: Re-enable largeMessageTest
47ac5f0 
The upstream issue [1] has been fixed in Chrome 89, which has just hit
the GitHub Actions virtual environment [2].

[1]: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3672
[2]: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210309.1
@gzm0 gzm0 linked a pull request Mar 15, 2021 that will close this issue
Fix #105: Re-enable largeMessageTest #122
Merged
@sjrd sjrd closed this as completed in #122 Mar 15, 2021
sjrd added a commit that referenced this issue Mar 15, 2021
@sjrd
Merge pull request #122 from gzm0/re-enable-large-message-test
5372e7f 
Fix #105: Re-enable largeMessageTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #105: Re-enable largeMessageTest gzm0/scala-js-env-selenium
3 participants
@sjrd @gzm0 @sbrunk