Skip to content

fix: build with CMAKE_CXX_STANDARD:STRING=11 on linux #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Feb 13, 2022

The CMake test suite doesn't pass when using the default detection mechanism on manylinux2014.
The CMake test suite is now run when building from sources.

This is using c++11 rather than c++14 because it's available on both manylinux1 & manylinux2014.

fixes #221

The CMake test suite doesn't pass when using the default detection mechanism on manylinux2014.
The CMake test suite is now run when building from sources.
Default is to exclude only `BootstrapTest`
On musllinux, also exclude `ExportImport`, `RunCMake.install` & `RunCMake.file-GET_RUNTIME_DEPENDENCIES`
@mayeut mayeut marked this pull request as ready for review February 19, 2022 17:04
@mayeut
Copy link
Contributor Author

mayeut commented Feb 19, 2022

I had to disable some tests for musllinux & opened a discussion about that at https://discourse.cmake.org/t/cmake-test-suite-failing-on-alpine-linux/5064
I did not get to the root cause of the failing tests. It looks like a bug in gcc with c++17 in devtoolset-10. Given there's a plan to move to devtoolset-11, finding the exact root cause might not be worse pursuing.
I did not change the required checks since there's been no review yet.

@mayeut mayeut requested review from jcfr and henryiii February 19, 2022 17:10
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis times out after 2/3 of the tests. Can we reduce there?

@mayeut
Copy link
Contributor Author

mayeut commented Mar 6, 2022

Travis times out after 2/3 of the tests. Can we reduce there?

I missed that. I thought it was only due to "negative credit balance" given the previous build passed without issues.
If it gets to flaky once there are credits, I'll see about getting more cores running the tests (but I guess it won't help in every case as it probably timed out because of side effects of the host doing something else on the side...).
If it doesn't help, we could target some specific tests suite to run but it gets trickier to do a proper selection.

Let's get this in as-is to get the fix in & go on from there then.

@mayeut mayeut merged commit 2ecf012 into scikit-build:master Mar 6, 2022
@mayeut mayeut deleted the cmake-test-suite branch March 6, 2022 08:58
@mayeut
Copy link
Contributor Author

mayeut commented Mar 6, 2022

Tests are showing both timeouts & failures with qemu builds. I'll try to address that "quickly" (given the time it takes with QEMU and that it might require a few trials...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cmake] Inconsistent behavior with the official version of cmake
2 participants