This repository was archived by the owner on Jun 1, 2024. It is now read-only.
Improved handle failures #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies to avoid the need for Serilog binding redirects in each project consuming this sink.
Rebuild Serilog.Sinks.Elasticsearch with the latest version of depend…
…2. Elasticsearch got many breaking changes, so update of the sink was not strightforward. My biggest area of concern is ElasticsearchSinkTestBase.cs - I think I shortcut some tests, because underlying interfaces got cut dramatically.
…es in Elasticsearch.NET behavior, so the tests may need to be corrected.
…sources, since the present implementation of reading from files were pretty overly complicated.
Fixed failing unittests
…sion 3 packages. Updated nuspec file to reference the Elasticsearch.net 2.
…-elasticsearch into leachdaniel-master
Added back off capability to the durable shipper
…or BulkResponse may be used.
…log-sinks-elasticsearch into tilign-tilign-version-patch # Conflicts: # src/Serilog.Sinks.Elasticsearch/Serilog.Sinks.Elasticsearch.csproj
Changed the link to the issues to point to this repository instead of main serilog one. Included a pointer to the changes.md file. [skip ci]
Conflicts: src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticSearchLogShipper.cs src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticSearchSink.cs src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticsearchSinkOptions.cs
2 tasks
|
See #127. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to the handle failure cases. Untested, I will take a closer look soon.