Skip to content

Avoid the need for a custom header file for ESP32 compilation. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

tschundler
Copy link
Contributor

Can be reverted when espressif/esp-idf#5429 is resolved.

@runger1101001
Copy link
Member

I like it. It will make everyone's life easier who is trying to use ESP32. At the same time, it will be backward compatible with anyone who has already modified the header.
If we merge it, we should remove that part of the ESP32 docs. @askuric what do you think? @byDagor ?

@runger1101001 runger1101001 requested a review from askuric April 25, 2021 09:23
@askuric
Copy link
Member

askuric commented Apr 25, 2021

Hey guys, I'll test it in the next few days
I've actually tried this on the beginning and it did not work.
You still needed the header file changes in order for the cast to work.

Let me look into it and if it works well be glad to merge it :)

@askuric askuric changed the base branch from master to dev May 4, 2021 17:38
@askuric
Copy link
Member

askuric commented May 4, 2021

Hey @tschundler and @runger1101001,

I've just tested the code and it works great!
No more need to update the mcpwm.h file 🥳 💪

Thanks a lot, I'm merging and I'll update the docs in the next iteration!

@askuric askuric merged commit 9f73d60 into simplefoc:dev May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants