-
Notifications
You must be signed in to change notification settings - Fork 56
Integrate 1920 Source Format and Grader #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
geshuming
merged 23 commits into
source-academy:master
from
geshuming:integrate-updated-grader
May 21, 2019
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fe804a0
Merge pull request #1 from source-academy/master
geshuming 6cc7e7f
Modified autograding_errors to autograding_summary
geshuming 6d906ba
integrate autograder and new xml format
geshuming f3ec4ab
updated schema
geshuming 643af0f
small refactor
geshuming 598dde2
Renamed template to solutionTemplate for viewer
geshuming 0dcf104
Merge branch 'master' into integrate-updated-grader
geshuming bd3c0e8
Removed redundant comments
geshuming 3c69c84
Merge branch 'integrate-updated-grader' of https://github.com/geshumi…
geshuming d873646
Added :score as a requirement for :testcase
geshuming f4f3d21
Removed redundant test and comment
geshuming 6be6438
Removed overriding of status in lambda_worker
geshuming 8263f52
Added more assertions to testcase test
geshuming 8a1c0e1
Small refactor
geshuming 89c8e62
Update lib/cadet/jobs/autograder/lambda_worker.ex
geshuming fcafcea
Merge branch 'integrate-updated-grader' of https://github.com/geshumi…
geshuming 7e53c52
Removed redundant pipeline
geshuming 9e2c2b9
Added test for when lambda crashes
geshuming ef44671
Shifted comments
geshuming 9b5ec90
Set parse_response to private
geshuming 6c6c6a7
Added comment for clarity
geshuming a5cb855
Refactored functions
geshuming 8eb05d2
Merge branch 'master' into integrate-updated-grader
geshuming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
lib/cadet/assessments/question_types/programming_question_testcases.ex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
defmodule Cadet.Assessments.QuestionTypes.Testcase do | ||
@moduledoc """ | ||
The Assessments.QuestionTypes.Testcase entity represents a public/private testcase. | ||
""" | ||
use Cadet, :model | ||
|
||
@primary_key false | ||
embedded_schema do | ||
field(:program, :string) | ||
field(:answer, :string) | ||
field(:score, :integer) | ||
end | ||
|
||
@required_fields ~w(program answer score)a | ||
|
||
def changeset(question, params \\ %{}) do | ||
question | ||
|> cast(params, @required_fields) | ||
|> validate_required(@required_fields) | ||
|> validate_number(:score, greater_than_or_equal_to: 0) | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
priv/repo/migrations/20190318070229_alter_answers_table_autograding_errors.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
defmodule Cadet.Repo.Migrations.AlterAnswersTableAutogradingErrors do | ||
use Ecto.Migration | ||
|
||
def change do | ||
rename(table(:answers), :autograding_errors, to: :autograding_results) | ||
end | ||
end |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.