Skip to content

Integrate 1920 Source Format and Grader #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 21, 2019
Merged

Integrate 1920 Source Format and Grader #363

merged 23 commits into from
May 21, 2019

Conversation

geshuming
Copy link
Contributor

CHANGES:

  • Added prepend
  • Renamed solutionTemplate to template
  • Added postpend
  • Removed grader from question
  • Added public to question
  • Added private to question
  • Renamed autograding_errors to autograding_results
  • Renamed autograding_errors to autograding_results
  • Updated XML parser to handle new tags
  • Refactored lambda worker to accept and store all results in a systematic format
  • Rewritten tests

TODO:

  • Add autograding_status and autograding_results to controller and view
  • Write new tests for new tags

@geshuming geshuming requested review from yyc and indocomsoft April 11, 2019 08:36
@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2415

  • 24 of 28 (85.71%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 98.007%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/cadet_web/views/assessments_view.ex 7 11 63.64%
Totals Coverage Status
Change from base Build 2412: -0.4%
Covered Lines: 836
Relevant Lines: 853
💛 - Coveralls

@martin-henz martin-henz requested a review from Aulud May 15, 2019 09:40
@geshuming geshuming changed the title Integrate updated grader and new XML format Integrate 1920 Source Format and Grader May 16, 2019
yyc
yyc approved these changes May 16, 2019
View reviewed changes
Copy link

@yyc yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

indocomsoft
indocomsoft requested changes May 16, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary comments. Halfway through, will try to finish the review over weekend.

In general, so far, remove all commented out codes. It's also part of good git etiquette

indocomsoft
indocomsoft requested changes May 17, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete review.

Overall looks good \o/, just some typical nitpicking by me

indocomsoft
indocomsoft requested changes May 18, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last nitpicking. After these are addressed, should be good to merge.

indocomsoft
indocomsoft approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM save for the 2 outstanding comments

@geshuming geshuming merged commit 61f9798 into source-academy:master May 21, 2019
@geshuming geshuming deleted the integrate-updated-grader branch May 28, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyc yyc yyc approved these changes

@indocomsoft indocomsoft indocomsoft approved these changes

@Aulud Aulud Awaiting requested review from Aulud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geshuming @coveralls @yyc @indocomsoft