-
Notifications
You must be signed in to change notification settings - Fork 172
Improve Functionality of Remote Execution Device Dialog #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Functionality of Remote Execution Device Dialog #2217
Conversation
Uses the alternative implementation of creating input groups as specified by docs: https://blueprintjs.com/docs/#core/components/text-inputs.input-group
Fixes bug where dialog would keep popping up when the workspace switches between mobile and desktop.
…r-scanning-autofill
Pull Request Test Coverage Report for Build 3056210332Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Btw @ianyong I just realised the mobile refactor was done on your feature branch, and this PR will most likely result in a merge conflict. I will be merging this first, as the Robot missions will be starting soon. Thanks!
Ok,, thanks for the heads up! |
Description
Added a new dependency:
"react-qr-reader": "^3.0.0-beta-1"
This MR includes various enhancements to the remote execution UI. Mainly, it is done to improve quality-of-life and the out-of-the box experience when pairing with a new device.
Summary of changes:
Type of change
How to test
some_string_here_a7Gxa
). At the same time, the address bar will not show the query parameter in the URL.This button should not be visible when editing a device, as the secret token is not editable in the case of editing. After clicking the button and accepting camera permissions, a camera window is shown, and the user can then start to scan the QR code. Clicking the button again will stop the camera. The camera will also auto-close once it detects and scans a QR code.
Once the camera has scanned a QR code, it will pre-fill the value into the 'secret' field, overriding any previous value that may be there. This field should remain editable by the user.
Checklist
I have updated the documentation(not applicable)