You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the SICP workspace makes use of the Playground component which introduces terrible coupling between the playground workspace and the SICP workspace. Thankfully, Folder mode has been implemented in a generic enough way that adding a new directory to the in-browser file system along with changing the Redux store defaults fixes the issue.
It turns out that the SICP workspace makes use of the Playground component which introduces terrible coupling between the playground workspace and the SICP workspace.
We really should spin out a separate component for the SICP workspace. As more features get added to the Source Academy, this tight coupling will only make development harder.
It turns out that the SICP workspace makes use of the Playground component which introduces terrible coupling between the playground workspace and the SICP workspace.
We really should spin out a separate component for the SICP workspace. As more features get added to the Source Academy, this tight coupling will only make development harder.
Agreed, could you kindly create an issue for this and link it to this PR? Thanks!
* Make Playground component workspace-agnostic
Why does the SICP workspace make use of the playground? Who thought
this was a great idea???
* Add BrowserFS directory for SICP workspace
* Set default file path when resetting SICP workspace
* Update tests
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turns out that the SICP workspace makes use of the
Playgroundcomponent which introduces terrible coupling between the playground workspace and the SICP workspace. Thankfully, Folder mode has been implemented in a generic enough way that adding a new directory to the in-browser file system along with changing the Redux store defaults fixes the issue.Fixes #2407.
Type of change
How to test
Test that the code snippets in the interactive SICP work.