Skip to content

Make frontend work with new module loading #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Conversation

leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Apr 7, 2024

Make the frontend compatible with the PR that was just merged.

I did have to modify the code for CToWasmHelper.ts, not sure who should be responsible for reviewing that

@martin-henz martin-henz mentioned this pull request Apr 7, 2024
@martin-henz martin-henz self-requested a review April 7, 2024 08:23
@martin-henz martin-henz enabled auto-merge (squash) April 7, 2024 08:23
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the module loading all asynchronous now. Tested that module loading works in the frontend.

@martin-henz martin-henz merged commit 3098e60 into master Apr 7, 2024
@martin-henz martin-henz deleted the module-loading branch April 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants