-
Notifications
You must be signed in to change notification settings - Fork 172
Miscellaneous changes and improvements #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the titles of the pages.
* Combine actions into one * Simplify column names
Also typed them for better type-safety.
Also improved some typing.
The idea is to try to minimise the need for CSS workarounds as much as possible. Should they be required nonetheless, they will be restored in a subsequent commit.
7 tasks
Pull Request Test Coverage Report for Build 9435958549Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9643811530Details
💛 - Coveralls |
sayomaki
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, although I have not tested all the changes yet. We shall see how this goes and fix any regressions if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #2837. Moves column sizing logic from the app to the browser (using flexbox), simplifying things.
Also moves out from Blueprint's CSS API for dialogs.
Type of change
Checklist