Skip to content

Miscellaneous changes and improvements #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 25, 2024
Merged

Miscellaneous changes and improvements #3001

merged 14 commits into from
Jun 25, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Jun 9, 2024

Description

Supersedes #2837. Moves column sizing logic from the app to the browser (using flexbox), simplifying things.

Also moves out from Blueprint's CSS API for dialogs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

Also updated the titles of the pages.
* Combine actions into one
* Simplify column names
Also typed them for better type-safety.
Also improved some typing.
The idea is to try to minimise the need for CSS workarounds as much as
possible. Should they be required nonetheless, they will be restored in
a subsequent commit.
@RichDom2185 RichDom2185 self-assigned this Jun 9, 2024
@RichDom2185 RichDom2185 mentioned this pull request Jun 9, 2024
7 tasks
@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9435906065

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 8 files are covered.
  • 11 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 31.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 0 2 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 0 2 0.0%
src/pages/academy/groundControl/GroundControl.tsx 0 2 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 0 2 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 1 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 1 0.0%
src/pages/academy/groundControl/GroundControl.tsx 1 0.0%
src/pages/academy/dashboard/Dashboard.tsx 2 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 2 0.0%
Totals Coverage Status
Change from base Build 9101202777: 0.04%
Covered Lines: 4891
Relevant Lines: 14648

💛 - Coveralls

@RichDom2185 RichDom2185 requested a review from sayomaki June 9, 2024 10:44
@RichDom2185 RichDom2185 marked this pull request as ready for review June 9, 2024 10:44
@RichDom2185 RichDom2185 mentioned this pull request Jun 9, 2024
7 tasks
@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9435958549

Details

  • 2 of 27 (7.41%) changed or added relevant lines in 11 files are covered.
  • 11 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 31.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 0 2 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 0 2 0.0%
src/pages/academy/groundControl/GroundControl.tsx 0 2 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 0 2 0.0%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx 0 3 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 0 3 0.0%
src/commons/editingWorkspace/EditingWorkspace.tsx 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 1 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 1 0.0%
src/pages/academy/groundControl/GroundControl.tsx 1 0.0%
src/pages/academy/dashboard/Dashboard.tsx 2 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 2 0.0%
Totals Coverage Status
Change from base Build 9101202777: 0.04%
Covered Lines: 4891
Relevant Lines: 14648

💛 - Coveralls

@RichDom2185 RichDom2185 requested a review from martin-henz June 24, 2024 10:31
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9643811530

Details

  • 2 of 27 (7.41%) changed or added relevant lines in 11 files are covered.
  • 11 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 31.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 0 2 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 0 2 0.0%
src/pages/academy/groundControl/GroundControl.tsx 0 2 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 0 2 0.0%
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx 0 3 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 0 3 0.0%
src/commons/editingWorkspace/EditingWorkspace.tsx 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 1 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 1 0.0%
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx 1 0.0%
src/pages/academy/groundControl/GroundControl.tsx 1 0.0%
src/pages/academy/dashboard/Dashboard.tsx 2 0.0%
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 2 0.0%
Totals Coverage Status
Change from base Build 9561526331: 0.04%
Covered Lines: 4891
Relevant Lines: 14648

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, although I have not tested all the changes yet. We shall see how this goes and fix any regressions if necessary.

@RichDom2185 RichDom2185 merged commit 0eb286d into master Jun 25, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the misc-1 branch June 25, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants