-
Notifications
You must be signed in to change notification settings - Fork 172
feat: add vscode slice for message passing with extension #3080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f9a23f9
feat: add vscode slice for message passing with extension
heyzec 2a9117d
Merge branch 'master' into sa-vscode
RichDom2185 9b001ad
fix tests
heyzec 4e43c66
Merge branch 'master' into sa-vscode
RichDom2185 93424b3
Update src/commons/application/actions/VscodeActions.ts
heyzec 084698d
address comments
heyzec 9e8afad
fix logical error
heyzec d92e4fc
Merge branch 'master' into sa-vscode
RichDom2185 c194ddb
Merge branch 'master' into sa-vscode
martin-henz d2e6701
refactor: improve typing of Messages util
heyzec 18d8814
Fetch user and course after login
RichDom2185 adc86c7
Remove unused code
heyzec dbc04b9
Polyfill window.confirm conditionally
heyzec d4a30cb
Merge branch 'master' into sa-vscode
heyzec b2c0843
fix linting errors
heyzec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { createActions } from 'src/commons/redux/utils'; | ||
|
||
const VscodeActions = createActions('vscode', { | ||
setVscode: 0 | ||
}); | ||
|
||
// For compatibility with existing code (actions helper) | ||
export default { | ||
...VscodeActions | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { createReducer, Reducer } from '@reduxjs/toolkit'; | ||
|
||
import { SourceActionType } from '../../utils/ActionsHelper'; | ||
import VscodeActions from '../actions/VscodeActions'; | ||
import { defaultVscode } from '../ApplicationTypes'; | ||
import { VscodeState } from '../types/VscodeTypes'; | ||
|
||
export const VscodeReducer: Reducer<VscodeState, SourceActionType> = ( | ||
state = defaultVscode, | ||
action | ||
) => { | ||
state = newVscodeReducer(state, action); | ||
return state; | ||
}; | ||
|
||
const newVscodeReducer = createReducer(defaultVscode, builder => { | ||
builder.addCase(VscodeActions.setVscode, state => { | ||
return { ...state, ...{ isVscode: true } }; | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export type VscodeState = { | ||
isVscode: boolean; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a guard, but shall we log such an event?
Technically we might be able to configure our deployment with
X-Frame-Options: DENY
to prevent embedding but let's look into it another timeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: also add Content-Security-Policy frame-ancestors 'none';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding header
X-Frame-Options: DENY
does not compromise the usability of the VSC extension, butContent-Security-Policy: frame-ancestors 'none';
will cause the request to be blocked within VSC.