-
Notifications
You must be signed in to change notification settings - Fork 172
Bump Phaser from v3.55.2 to v3.87.0 #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 13569710291Details
💛 - Coveralls |
Supersedes #3087 |
Marked as draft while checking if chapter errors are due to backend setup or the phaser upgrade. |
A deeper look found that errors were coming from a failure to load assets from S3 bucket, likely caused by lack of read access. |
…l usage during development
…nto bump-phaser-justatin555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (minor nit)! I think it's great that we are keeping phaser updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
path
as explicit dev dependency as Phaser 3.87.0 no longer lists itphaser3spectorjs
to satisfy Phaser 3.87.0 undeclared dependency (unknown problem with Phaser's build process)undefined
scene.input.mouse
orscene.input.keyboard
when disabled in configType of change
How to test
yarn test
, all test cases passedyarn start
, Source Academy launches and mock story chapters load properlyChecklist