Skip to content

Bump Phaser from v3.55.2 to v3.87.0 #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Feb 27, 2025
Merged

Bump Phaser from v3.55.2 to v3.87.0 #3090

merged 26 commits into from
Feb 27, 2025

Conversation

JustATin555
Copy link
Contributor

@JustATin555 JustATin555 commented Feb 4, 2025

Description

  • Bump Phaser from 3.55.2 to 3.87.0 and address any breaking changes
  • Add path as explicit dev dependency as Phaser 3.87.0 no longer lists it
  • Add phaser3spectorjs to satisfy Phaser 3.87.0 undeclared dependency (unknown problem with Phaser's build process)
  • Add a guard for undefined scene.input.mouse or scene.input.keyboard when disabled in config
  • Add a try/catch to ensure missing background music assets do not cause fatal errors in Game
  • Add a new .env variable, REACT_APP_USE_EMPTY_ASSET_PREFIX, which controls whether or not toS3Path() uses an asset prefix provided by the backend when loading images / sprites
  • ParserValidator should now check default SoundAssets if it cannot find a BGM or SFX in the checkpoint

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • Tested with yarn test, all test cases passed
  • Tested with yarn start, Source Academy launches and mock story chapters load properly
  • Tested with actual story chapters

Checklist

  • I have tested this code
  • I have updated the documentation

@JustATin555 JustATin555 self-assigned this Feb 4, 2025
@JustATin555 JustATin555 linked an issue Feb 4, 2025 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13569710291

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 31.117%

Totals Coverage Status
Change from base Build 13536487393: 0.003%
Covered Lines: 4872
Relevant Lines: 14778

💛 - Coveralls

@JustATin555 JustATin555 changed the title Bump phaser justatin555 Bump Phaser 3.55.2 to 3.87.0 Feb 4, 2025
@JustATin555 JustATin555 added dependencies This pull request updates dependency files game All game related ideas, bugs, fixes labels Feb 4, 2025
@JustATin555 JustATin555 changed the title Bump Phaser 3.55.2 to 3.87.0 Bump Phaser from v3.55.2 to v3.87.0 Feb 4, 2025
@RichDom2185
Copy link
Member

Supersedes #3087

@JustATin555 JustATin555 marked this pull request as draft February 5, 2025 13:27
@JustATin555
Copy link
Contributor Author

JustATin555 commented Feb 5, 2025

Marked as draft while checking if chapter errors are due to backend setup or the phaser upgrade.

@JustATin555 JustATin555 marked this pull request as ready for review February 7, 2025 05:58
@JustATin555
Copy link
Contributor Author

A deeper look found that errors were coming from a failure to load assets from S3 bucket, likely caused by lack of read access.

@JustATin555 JustATin555 added the blocking Finishing this opens up other stuff label Feb 17, 2025
@JustATin555 JustATin555 mentioned this pull request Feb 17, 2025
7 tasks
@JustATin555 JustATin555 removed the blocking Finishing this opens up other stuff label Feb 17, 2025
Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minor nit)! I think it's great that we are keeping phaser updated.

Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhw-1 lhw-1 merged commit 56b1ab0 into master Feb 27, 2025
8 checks passed
@lhw-1 lhw-1 deleted the bump-phaser-justatin555 branch February 27, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This pull request updates dependency files game All game related ideas, bugs, fixes
Development

Successfully merging this pull request may close these issues.

Bump Phaser from 3.55.2 to 3.87.0
5 participants