Skip to content

hotfix: fix conduit race condition resulting in dropped messages #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

tsammeow
Copy link
Contributor

@tsammeow tsammeow commented Mar 6, 2025

Description

this issue causes runner to miss start evaluation message sometimes

patched in conductor repo; upgrading version here to fix

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

…ed, causing runner to miss start evaluation message sometimes
@tsammeow tsammeow requested a review from RichDom2185 March 6, 2025 19:48
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) March 6, 2025 19:48
@RichDom2185 RichDom2185 merged commit c63c423 into master Mar 6, 2025
8 checks passed
@RichDom2185 RichDom2185 deleted the hotfix/conductor-evaluation branch March 6, 2025 19:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13706915502

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.129%

Totals Coverage Status
Change from base Build 13668147867: 0.0%
Covered Lines: 4887
Relevant Lines: 14807

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants