Skip to content

Fix service workers not working after upgrading to rsbuild #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2025

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented Jun 24, 2025

Description

Fix service workers no longer working after switching to rsbuild, added @aaroon/workbox-rspack-plugin to build and generate service worker file using workbox.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  1. yarn build
  2. yarn preview
  3. Test in browser locally

Checklist

  • I have tested this code
  • I have updated the documentation

@sayomaki sayomaki requested a review from RichDom2185 June 24, 2025 09:39
@coveralls
Copy link

coveralls commented Jun 24, 2025

Pull Request Test Coverage Report for Build 15847081575

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 44.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rsbuild.config.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
rsbuild.config.ts 2 0.0%
Totals Coverage Status
Change from base Build 15845909436: -0.004%
Covered Lines: 10081
Relevant Lines: 21130

💛 - Coveralls

@RichDom2185 RichDom2185 enabled auto-merge (squash) June 24, 2025 09:47
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 4bf1f63 into master Jun 24, 2025
9 checks passed
@RichDom2185 RichDom2185 deleted the fix-service-workers branch June 24, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants