Skip to content

Mission editing update #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/components/incubator/EditingWorkspace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { ControlBarProps } from '../workspace/ControlBar';
import { SideContentProps } from '../workspace/side-content';
import ToneMatrix from '../workspace/side-content/ToneMatrix';
import {
GlobalDeploymentTab,
DeploymentTab,
GradingTab,
ManageQuestionTab,
QuestionTemplateTab,
Expand Down Expand Up @@ -188,8 +188,8 @@ class AssessmentWorkspace extends React.Component<AssessmentWorkspaceProps, ISta
const question = this.state.assessment!.questions[questionId];
const library =
question.library.chapter === -1
? question.library
: this.state.assessment!.globalDeployment!;
? this.state.assessment!.globalDeployment!
: question.library;
const editorValue =
question.type === QuestionTypes.programming
? question.answer !== null
Expand Down Expand Up @@ -293,11 +293,25 @@ class AssessmentWorkspace extends React.Component<AssessmentWorkspaceProps, ISta
},
{
label: `Manage Global Deployment`,
icon: IconNames.TAG,
icon: IconNames.GLOBE,
body: (
<GlobalDeploymentTab
<DeploymentTab
assessment={assessment}
pathToLibrary={['globalDeployment']}
updateAssessment={this.updateEditAssessmentState}
isGlobalDeployment={true}
/>
)
},
{
label: `Manage Local Deployment`,
icon: IconNames.HOME,
body: (
<DeploymentTab
assessment={assessment}
pathToLibrary={['questions', questionId, 'library']}
updateAssessment={this.updateEditAssessmentState}
isGlobalDeployment={false}
/>
)
}
Expand Down
32 changes: 20 additions & 12 deletions src/components/incubator/ImportFromFileComponent.tsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,30 @@
import { FileInput } from '@blueprintjs/core';
import { IconNames } from '@blueprintjs/icons';
import * as React from 'react';
import { parseString } from 'xml2js';
import { IAssessment, IAssessmentOverview } from '../../components/assessment/assessmentShape';
import { makeEntireAssessment, retrieveLocalAssessment } from '../../utils/xmlParser';
import { controlButton } from '../commons';
import { assessmentTemplate, overviewTemplate } from '../incubator/assessmentTemplates';

type Props = {
newAssessment: (assessment: IAssessment) => void;
updateEditingOverview: (overview: IAssessmentOverview) => void;
};

export class ImportFromFileComponent extends React.Component<Props, { isInvalidXml: boolean }> {
type State = {
fileInputText: string;
};

export class ImportFromFileComponent extends React.Component<Props, State> {
private fileReader: FileReader;
public constructor(props: any) {
super(props);
this.handleFileRead = this.handleFileRead.bind(this);
this.handleChangeFile = this.handleChangeFile.bind(this);
this.makeMission = this.makeMission.bind(this);
this.state = {
isInvalidXml: false
fileInputText: 'Import XML'
};
}

Expand All @@ -32,13 +39,14 @@ export class ImportFromFileComponent extends React.Component<Props, { isInvalidX
return (
<div>
<div>Please ensure that the xml uploaded is trustable.</div>
<input type="file" id="file" accept=".xml" onChange={this.handleChangeFile} />
<button onClick={this.makeMission}>Make New Mission</button>
{this.state.isInvalidXml ? (
<div>The xml uploaded is invalid.</div>
) : (
<div>You can edit this card</div>
)}
<div>
<FileInput
text={this.state.fileInputText}
inputProps={{ accept: '.xml' }}
onChange={this.handleChangeFile}
/>
</div>
<div>{controlButton('Make New Mission', IconNames.NEW_OBJECT, this.makeMission)}</div>
</div>
);
}
Expand All @@ -57,13 +65,13 @@ export class ImportFromFileComponent extends React.Component<Props, { isInvalidX
localStorage.setItem('MissionEditingAssessmentSA', JSON.stringify(entireAssessment[1]));
this.props.newAssessment(entireAssessment[1]);
this.setState({
isInvalidXml: false
fileInputText: 'Success!'
});
} catch (err) {
// tslint:disable-next-line:no-console
console.log(err);
this.setState({
isInvalidXml: true
fileInputText: 'Invalid XML!'
});
}
});
Expand All @@ -79,7 +87,7 @@ export class ImportFromFileComponent extends React.Component<Props, { isInvalidX
}
};

private makeMission = (e: any) => {
private makeMission = () => {
localStorage.setItem('MissionEditingOverviewSA', JSON.stringify(overviewTemplate));
this.props.updateEditingOverview(overviewTemplate);

Expand Down
2 changes: 1 addition & 1 deletion src/components/incubator/assessmentTemplates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '../../components/assessment/assessmentShape';
import { mock2DRuneLibrary } from '../../mocks/assessmentAPI';

const emptyLibrary: Library = {
export const emptyLibrary: Library = {
chapter: -1,
external: {
name: 'NONE',
Expand Down
Loading