Mission editing master

[martin-henz]

No description provided.

[martin-henz]

Can you guys put some example mission files in the repo "assessments" in folder "samples". Maybe you want to make clear by the choice of their filenames that they are meant as test files for the mission editor.

[gerhean]

This tool is an editor: It allows the user to open an existing mission (that is stored in a file), create a new mission, and save the current mission (to a file). The notion of "import" and "export" is not appropriate here. We should take a look at established editors such as Word, and adopt their terminology.

The options in "Mission Control" should be:
New Mission (creates a new mission without saving it anywhere)
Open... (prompts the user to navigate to a file in a finder, and open it)
Save (saves the current mission to the most recently "Open..." or "Save as..." location, or prompts the user to give a location, if the current mission is a "New Mission")
Save as... (prompts the user to give a location)

This scheme will allow us to eliminate the highly unusual choice of setting a Filename under "Other options". A filename is not an "option" but a central concept for such an editor.

It is not possible to force users to save at any particular location due to Javascript security concerns. Only the client, in their browser, set that they want to be prompted where to save their files.

Established editors such as Word are native apps, hence they are able to perform these functions, as opposed to our mission editor being a web app and hence having more restrictions.

The purpose of including a "filename" field is to make sure, as far as possible, that the file that is opened in the editor, is the file that is saved. This is as the mission name is rarely the filename, and I felt it would be convenient if the author did not need to change the filename back to the original filename whenever the file is shared.

[martin-henz]

The options in "Mission Control" should be:
New Mission (creates a new mission without saving it anywhere)
Open... (prompts the user to navigate to a file in a finder, and open it)
Save (saves the current mission to the most recently "Open..." or "Save as..." location, or prompts the user to give a location, if the current mission is a "New Mission")
Save as... (prompts the user to give a location)

I see. How about this, then:

The options in "Mission Control" should be:
New Mission (creates a new mission without saving it anywhere)
Open... (prompts the user to navigate to a file in a finder, and open it)
Save (saves the current mission using the most recently "Open..." or "Save as..." file name, or prompts the user to give a file name in an input field, if the current mission is a "New Mission")
Save as... (prompts the user to give a file name in an input field)
Play (opens the current mission, as a real mission, without editing)

[gerhean]

There is a spurious closed bracket in the template editor.

Fixed

src/components/workspace/ControlBar.tsx

  private replControl() {
    // toggleEditMode can be null or undefined here, thus !=
    const toggleEditModeButton =
      this.props.toggleEditMode !== null ? (

In Playground, the toggleEditMode appears to be undefined, not null. Thus, != might be more appropriate. Otherwise this happens:

Fixed

The question template does not seem to be saved properly.

How to reproduce the bug:
(1) create a new mission
(2) edit the template of Question 1
(3) save
(4) re-load the mission
Now the template is back to the original "//This is a mock solution template".

I can't seem to reproduce this bug. Maybe it happens if you click on the save button too fast.

In addition to the usual features "New Mission", "Save", "Save As..." and "Open..." we should have a "Play" option in the "Mission Control" interface. This feature would load the mission without any of the editing features. It would allow us to test the client-side features of the mission before uploading it to any server.

I think all client-side features are already testable even with the editing features.

[martin-henz]

We are almost there with this.

As discussed, let's remove the buttons "Save" and "Reset".

Changes in the template (and everywhere else) should have immediate effect.

Shuming's "Reset" button should therefore work as expected: It should copy the template from the right hand side to the left hand side.

Therefore, you can remove the button "Copy to Editor".

[gerhean]

Tests still missing.

[gerhean]

Test still missing.
Undo button to be added later.