Skip to content

Add operator, boost, prefix length, and max expansions to MultiMatchQuery #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

floristenhove
Copy link
Contributor

This PR enhances the MultiMatchQuery class by adding new parameters. It also introduces a comprehensive test suite for the MultiMatchQuery class to ensure correctness and robustness, in line with the already existing MatchQueryTest.

Enhancements to MultiMatchQuery:

  • Added support for new parameters: operator, boost, prefixLength, and maxExpansions. These parameters allow more fine-grained control over the query behavior. I do feel the arguments are getting to a point that there are too many, especially when we would add even more. Ideally, this should be approached differently, but this would require some more discussion.

Copy link
Collaborator

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bram-pkg bram-pkg merged commit a1aace7 into spatie:main Jun 5, 2025
20 checks passed
@floristenhove floristenhove deleted the feature/expand-multimatch-query branch June 5, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants