Mockito fails to verify mocked @Service when service contains @Retryable methods

[pearj]

I'm using spring-boot 1.4.0.FINAL and I'm having trouble when I have a mocked @Service which has @Retryable annotations in the class. When I call Mockito.verify() I get an UnfinishedVerificationException exception:

12:05:36.554 [main] DEBUG org.springframework.test.context.support.AbstractDirtiesContextTestExecutionListener - After test method: context [DefaultTestContext@5ec0a365 testClass = MockBatchTestWithRetryVerificationFailures, testInstance = sample.batch.MockBatchTestWithRetryVerificationFailures@5abca1e0, testMethod = batchTest@MockBatchTestWithRetryVerificationFailures, testException = org.mockito.exceptions.misusing.UnfinishedVerificationException: 
Missing method call for verify(mock) here:
-> at sample.batch.service.MyRetryService$$FastClassBySpringCGLIB$$7573ce2a.invoke(<generated>)

Example of correct verification:
    verify(mock).doSomething()

This looks very similar to #5837, in fact, I managed to hack to workaround based off that issue:

See: sample.batch.MockBatchTestWithRetryVerificationFailuresWorkaround.batchTest()

@Test
public void batchTest() throws Exception {
    service.process();

    if (service instanceof Advised) {
        service = (MyRetryService) ((Advised) service).getTargetSource().getTarget();
    }

    verify(service).process();
    validateMockitoUsage();
}

I have put an example project together here that reproduces this issue: https://github.com/pearj/spring-boot-batch-retry-issue
For the failure case see: sample.batch.MockBatchTestWithRetryVerificationFailures.batchTest()

Is it possible for a transparent fix somehow?

I also have this on stackoverflow

[philwebb]

Could you please give the latest SNAPSHOT version a quick try as we've recently fixed a number of very similar issues.

[pearj]

How recent? I tried 1.41.SNAPSHOT today
On Wed, 7 Sep 2016 at 9:28 PM, Phil Webb notifications@github.com wrote:

Could you please give the latest SNAPSHOT version a quick try as we've
recently fixed a number of very similar issues.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6828 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOg_dpNYC8QUEnGL9OtmL8PzPCeCOM9ks5qnp_MgaJpZM4J2ggw
.

[pearj]

1.41.BUILD-SNAPSHOT that is

[philwebb]

That's the most recent. Thanks for giving it a go.

[wilkinsona]

Looks like the build's broken so the latest snapshot is stale. Something to do with the Bamboo upgrade?

[philwebb]

I don't think there's much we can do automatically when the mock method is directly used, however, if you use @MockBean with the latest snapshot then I think things will work:

@ActiveProfiles("Test")
@ContextConfiguration(classes = { SampleBatchApplication.class }, loader = AnnotationConfigContextLoader.class)
@RunWith(SpringRunner.class)
public class MockBatchTestWithRetryVerificationFailures {

    @MockBean
    MyRetryService service;

    @Test
    public void batchTest() {
        service.process();
        verify(service).process();
        validateMockitoUsage();
    }

}