DATAMONGO-479 - Add support for calling functions. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +112,8 @@ public CustomConversions(List<?> converters) { | |||
| toRegister.add(StringToURLConverter.INSTANCE); | |||
| toRegister.add(DBObjectToStringConverter.INSTANCE); | |||
| toRegister.add(TermToStringConverter.INSTANCE); | |||
| toRegister.add(CallableMongoScriptToDBObjectConverter.INSTNACE); | |||
There was a problem hiding this comment.
fixed - thanks @thomasdarimont !
christophstrobl
force-pushed
the
issue/DATAMONGO-479
branch
from
9451c0c to
be38efa
Compare
christophstrobl
force-pushed
the
issue/DATAMONGO-479
branch
from
0df88c6 to
b65ddd5
Compare
| * @param name | ||
| * @return {@literal null} if not found. | ||
| */ | ||
| CallableMongoScript load(Serializable name); |
There was a problem hiding this comment.
Why Serializable? For supporting String and ObjectIds?
There was a problem hiding this comment.
Good point. Yes, would have been for calling scripts via ObjectId, but once I tried to do so it turned out that one can store the script using ObjectId but won't be able to call it later as the name needs to be a String. Should be String instead of Serializable then.
christophstrobl
force-pushed
the
issue/DATAMONGO-479
branch
2 times, most recently
from
ff494b7 to
c7db98b
Compare
Prepare issue branch.
We added ScriptOperations to MongoTemplate. Those allow storage and execution of java script function directly on the MongoDB server instance. Having ScriptOperations in place builds the foundation for annotation driver support in repository layer.
Fix broken tests by avoiding initialization of MongoRepositories on package as this would trigger index creation which is likely to fail on older server versions.
Use more explicit wording and add methods for checking existence of functions via name as well as listing names of available scripts. Updated javaDoc and reference documentation.
christophstrobl
force-pushed
the
issue/DATAMONGO-479
branch
from
c7db98b to
3c442c0
Compare
Use getCode() instead of toString for converting o.b.t.Code objects. This works fine for MongoDB Java driver versions 2 and 3.
christophstrobl
force-pushed
the
issue/DATAMONGO-479
branch
from
3c442c0 to
7f86a05
Compare
christophstrobl
added a commit
that referenced
this pull request
Mar 4, 2015
We added ScriptOperations to MongoTemplate. Those allow storage and execution of java script function directly on the MongoDB server instance. Having ScriptOperations in place builds the foundation for annotation driver support in repository layer. Original pull request: #254.
odrotbohm
added a commit
that referenced
this pull request
Mar 4, 2015
Removed ServersideJavaScript abstraction as we still had to resort on instanceof checks and it created more ambiguities than it helped (e.g. in a script with name and code, which of the two get's executed?). We now have an ExecutableMongoScript which is code only and a NamedMongoScript, which basically is the former assigned to a name. Execution can be triggered on the former or a name. ScriptOperations.exists(…) now returns a primitive boolean to avoid null checks. JavaDoc. Original pull request: #254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
ScriptOperationstoMongoTemplate. Those allow storage and execution of javascript function directly on the MongoDB server instance. HavingScriptOperationsin place builds the foundation for annotation driver support in repository layer.