DATAMONGO-1165 - Add support for Streaming large result lists. #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdarimont
force-pushed
the
issue/DATAMONGO-1165
branch
from
c9e497e to
5eecc33
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Feb 16, 2015
Initial PoC for a MongoDB Cursor backed Iterator that allows fetching of large result sets. Original pull request: #274.
|
There are a few aspects we should improve on here:
|
added 4 commits
February 24, 2015 16:56
Prepare issue branch.
Initial PoC for a MongoDB Cursor backed Iterator that allows fetching of large result sets. Original pull request: #274.
Initial support for CloteableIterable and Java 8 Stream as return type of custom Repository finder methods.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1165
branch
from
5eecc33 to
2144209
Compare
| /** | ||
| * @author Thomas Darimont | ||
| */ | ||
| final class StreamExecution extends CursorBackedExecution { |
There was a problem hiding this comment.
Do you think it's possible to move that into Spring Data Commons and rather turn it into a post-processing step in case the execution returns a CloseableIterable but effectively needs to be a Stream (similarly to what we already do with Optionals. I think this would allow us to automatically support Stream as return type on all stores that implement the execution into a ClosableIterable.
added 2 commits
February 25, 2015 17:39
Added ExceptionTranslation to CloseableIterableCursorAdapter.
Introduced new executeAsStream(..) method to MongoOperations in the context of pushing cursor creation and wrapping in CloseableIterator down to MongoTemplate.
| final class StreamExecution extends CursorBackedExecution { | ||
|
|
||
| @Override | ||
| Object execute(Query query) { |
There was a problem hiding this comment.
I think part of this code could be moved to SD Commons.
added 2 commits
March 2, 2015 17:17
Added support for translation of MongoDB Exceptions as well as potential event propagation via ReadDbObjectCallback in MongoTemplate.executeAsStream(..).
Adapted Java 8 Stream creation to new Java8StreamUtils from SD Commons.
thomasdarimont
pushed a commit
that referenced
this pull request
Mar 3, 2015
…ository methods. Added support for a MongoDB Cursor backed Iterator that allows the usage of a Java 8 Stream at the repository level. Original pull request: #274.
odrotbohm
added a commit
that referenced
this pull request
Mar 3, 2015
Renamed MongoOperations executeAsStream(…) to stream(…). Make use of Spring Data Commons StreamUtils in AbstractMongoQuery's StreamExecution. Moved test case from PersonRepositoryIntegrationTests to AbstractPersonRepositoryIntegrationTests to make sure they're executed for all sub-types. Original pull request: #274.
odrotbohm
added a commit
that referenced
this pull request
Mar 3, 2015
Renamed MongoOperations executeAsStream(…) to stream(…). Make use of Spring Data Commons StreamUtils in AbstractMongoQuery's StreamExecution. Moved test case from PersonRepositoryIntegrationTests to AbstractPersonRepositoryIntegrationTests to make sure they're executed for all sub-types. Original pull request: #274.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PoC for a MongoDB Cursor backed Iterator that allows fetching of large result sets.