DATAREDIS-562 - Add support for BITFIELD. #227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should wait for Jedis 2.9.1 and Lettuce 4.2.3 to arrive before we merge that one.
|
christophstrobl
force-pushed
the
issue/DATAREDIS-562
branch
from
f90874b to
5448a31
Compare
mp911de
added a commit
that referenced
this pull request
May 2, 2018
Add OBJECT command support for Jedis Cluster. Original pull request: #227.
mp911de
force-pushed
the
issue/DATAREDIS-562
branch
from
5448a31 to
dd771f0
Compare
Prepare issue branch.
We now offer support for BITFIELD via RedisConnection and RedisClusterConnection using Lettuce and Jedis. connection.bitfield(key, newBitfieldCommand() .set(INT_8).valueAt(offset(0).multipliedByTypeLength()).to(100) .incr(signed(8)).valueAt(offset(102)).overflow(FAIL).by(1));
Move BitfieldCommand to top-level type BitFieldSubCommands. Use primitives in command objects. Add toString methods. Add utility methods to extract responses from Jedis Client. Use Connection.execute(…) to invoke BITFIELD using Jedis. Fix Overflow values to string rendering. Convert test ticket references to new format.
mp911de
force-pushed
the
issue/DATAREDIS-562
branch
from
dd771f0 to
9404bda
Compare
mp911de
pushed a commit
that referenced
this pull request
May 3, 2018
We now offer support for BITFIELD via RedisConnection and RedisClusterConnection using Lettuce and Jedis. connection.bitField(key, create() .set(INT_8).valueAt(offset(0).multipliedByTypeLength()).to(100) .incr(signed(8)).valueAt(offset(102)).overflow(FAIL).by(1)); Original pull request: #227.
mp911de
added a commit
that referenced
this pull request
May 3, 2018
Move BitfieldCommand to top-level type BitFieldSubCommands. Use primitives in command objects. Add toString methods. Add utility methods to extract responses from Jedis Client. Use Connection.execute(…) to invoke BITFIELD using Jedis. Fix Overflow values to string rendering. Convert test ticket references to new format. Original pull request: #227.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now offer support for
BITFIELDviaRedisConnectionandRedisClusterConnectionusing Lettuce and Jedis.