-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Upgrade to Jedis 4.2 #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Upgrade to Jedis 4.2 #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for GEOSEARCH, GEOSEARCHSTORE, XCLAIMJUSTID, and XPENDING summary.
Reformat code. Reduce visibility, simplify code.
Also, refine docs regarding driver ordering.
Consistently use InvalidDataAccessApiUsageException to signal that an operation is not allowed/supported in the current mode of operation.
Replace converter objects with conversion within the actual method to remove indirections.
75f0bc7
to
0fc4445
Compare
Paging @gkorland |
Thanks @mp911de for the PR. @christophstrobl Can you please review? |
christophstrobl
pushed a commit
that referenced
this pull request
May 18, 2022
Reformat code. Reduce visibility, simplify code. Original Pull Request: #2287
christophstrobl
pushed a commit
that referenced
this pull request
May 18, 2022
Also, refine docs regarding driver ordering. Original Pull Request: #2287
christophstrobl
pushed a commit
that referenced
this pull request
May 18, 2022
Consistently use InvalidDataAccessApiUsageException to signal that an operation is not allowed/supported in the current mode of operation. Replace converter objects with conversion within the actual method to remove indirections. Original Pull Request: #2287
christophstrobl
added a commit
that referenced
this pull request
May 18, 2022
Original Pull Request: #2287
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Jedis 4. This upgrade introduces breaking changes as several Jedis types were removed (e.g.
JedisShardInfo
) or relocated to packages (e.g. response and parameter types).It is no longer possible to use pipelining and transactions together.
Closes #2212