Skip to content

BZPOPMAX returns minimum value when called with a Duration #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

jdeppe-pivotal
Copy link
Contributor

  • Specifically, usage of the API ZSetOperations.popMax(K key, Duration timeout)
    will produce incorrect results.
  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

- Specifically, usage of the API `ZSetOperations.popMax(K key, Duration timeout)`
  will produce incorrect results.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2022
@mp911de mp911de added this to the 2.6.7 (2021.1.7) milestone Sep 16, 2022
@mp911de mp911de merged commit d51ce05 into spring-projects:main Sep 16, 2022
mp911de pushed a commit that referenced this pull request Sep 16, 2022
`ZSetOperations.popMax(K key, Duration timeout)` now calls `popMax` instead the previously incorrect method `popMin`.

Closes #2323
mp911de pushed a commit that referenced this pull request Sep 16, 2022
`ZSetOperations.popMax(K key, Duration timeout)` now calls `popMax` instead the previously incorrect method `popMin`.

Closes #2323
@mp911de
Copy link
Member

mp911de commented Sep 16, 2022

Thank you for your contribution. That's merged and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants