-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix potential NullPointerException
when using Jedis Cluster BZPOP*
#2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jdeppe-pivotal
wants to merge
1
commit into
spring-projects:main
from
jdeppe-pivotal:fix-npe-jedis-bzpop
Closed
Fix potential NullPointerException
when using Jedis Cluster BZPOP*
#2324
jdeppe-pivotal
wants to merge
1
commit into
spring-projects:main
from
jdeppe-pivotal:fix-npe-jedis-bzpop
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the Jedis-based implementations of bzpopmin and bzpopmax, a NPE is thrown if the provided timeout elapses and the server responds with a null array.
This is an example stacktrace:
|
NullPointerException
when using Jedis Cluster BZPOP*
mp911de
added a commit
that referenced
this pull request
Sep 16, 2022
Add author tags. Align Lettuce BZPOPMIN/MAX tests. Increase timeout to 10ms as Redis blocks indefinitely if the timeout is less than 0.01. See #2324
mp911de
pushed a commit
that referenced
this pull request
Sep 16, 2022
For the Jedis-based implementations of bzpopmin and bzpopmax, a NPE is thrown if the provided timeout elapses and the server responds with a null array. Closes #2324
mp911de
added a commit
that referenced
this pull request
Sep 16, 2022
Add author tags. Align Lettuce BZPOPMIN/MAX tests. Increase timeout to 10ms as Redis blocks indefinitely if the timeout is less than 0.01. See #2324
mp911de
pushed a commit
that referenced
this pull request
Sep 16, 2022
For the Jedis-based implementations of bzpopmin and bzpopmax, a NPE is thrown if the provided timeout elapses and the server responds with a null array. Closes #2324
mp911de
added a commit
that referenced
this pull request
Sep 16, 2022
Add author tags. Align Lettuce BZPOPMIN/MAX tests. Increase timeout to 10ms as Redis blocks indefinitely if the timeout is less than 0.01. See #2324
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thrown if the provided timeout elapses and the server responds with a
null array.