Full editing pass for Spring Data Redis #331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I edited for spelling, punctuation, grammar, clarity, and cross-references. I also pulled one piece of content that was being reused into its own file, so that I could include it rather than repeat it.
|
Related ticket: https://jira.spring.io/browse/DATAREDIS-825 |
mp911de
approved these changes
May 4, 2018
| :revnumber: {version} | ||
| :revdate: {localdate} | ||
| :toc: | ||
| :toc-placement!: | ||
| :toc: left |
There was a problem hiding this comment.
Leaving out this change until we have all modules polished up so we can apply TOC placement for all modules in almost a single shot.
|
|
||
| To help with the asynch manner of messages, the container requires a `java.util.concurrent.Executor` ( or Spring's `TaskExecutor`) for dispatching the messages. Depending on the load, the number of listeners or the runtime environment, one should change or tweak the executor to better serve her needs - in particular in managed environments (such as app servers), it is highly recommended to pick a a proper `TaskExecutor` to take advantage of its runtime. | ||
| To help with the asynchronous nature of messages, the container requires a `java.util.concurrent.Executor` ( or Spring's `TaskExecutor`) for dispatching the messages. Depending on the load, the number of listeners, or the runtime environment, you should change or tweak the executor to better serve your needs. In particular, in managed environments (such as app servers), it is highly recommended to pick a proper `TaskExecutor` to take advantage of its runtime. | ||
| // TODO How can one know which is "proper"? |
There was a problem hiding this comment.
Regarding the TODO: The proper aspect comes from the context in which components are used. We assume that users of app servers are aware of their runtime and the threading facilities it provides.
mp911de
pushed a commit
that referenced
this pull request
May 4, 2018
I edited for spelling, punctuation, grammar, clarity, and cross-references. I also pulled one piece of content that was being reused into its own file, so that I could include it rather than repeat it. Original pull request: #331.
mp911de
added a commit
that referenced
this pull request
May 4, 2018
Fix typos. Remove redundant mention of JDK requirements. Original pull request: #331.
mp911de
pushed a commit
that referenced
this pull request
May 4, 2018
I edited for spelling, punctuation, grammar, clarity, and cross-references. I also pulled one piece of content that was being reused into its own file, so that I could include it rather than repeat it. Original pull request: #331.
mp911de
added a commit
that referenced
this pull request
May 4, 2018
Fix typos. Remove redundant mention of JDK requirements. Original pull request: #331.
mp911de
pushed a commit
that referenced
this pull request
May 4, 2018
I edited for spelling, punctuation, grammar, clarity, and cross-references. I also pulled one piece of content that was being reused into its own file, so that I could include it rather than repeat it. Original pull request: #331.
mp911de
added a commit
that referenced
this pull request
May 4, 2018
Fix typos. Remove redundant mention of JDK requirements. Original pull request: #331.
|
That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited for spelling, punctuation, grammar, clarity, and cross-references. I also pulled one piece of content that was being reused into its own file, so that I could include it rather than repeat it.