DATAREDIS-999 - Use UsingWhen to apply functions to reactive Redis connections #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotmrv
reviewed
Jun 28, 2019
|
|
||
| return Flux.from(postProcessResult(result, connToUse, false)).doFinally(signal -> conn.close()); | ||
| }, ReactiveRedisConnection::closeLater, ReactiveRedisConnection::closeLater); |
There was a problem hiding this comment.
Is it really nonblocking call?
I see that ReactiveRedisConnection::closeLater returns Mono, but inside LettuceReactiveRedisConnection it uses call marked as blocking
There are situations when Subscription could be canceled in non blocking thread and this code will block nonblocking thread.
There was a problem hiding this comment.
Good catch. That's fixed now.
mp911de
force-pushed
the
issue/DATAREDIS-999
branch
from
2131f0c to
feed7b6
Compare
…nnections. We now use Flux.usingWhen() to apply functions on reactive Redis connections and to release connections calling non-blocking methods.
mp911de
force-pushed
the
issue/DATAREDIS-999
branch
from
feed7b6 to
766bd8b
Compare
|
Connections are used either for data or pub/sub. Using both aspects does not happen in Spring Data Redis's support. However, someone could still invoke pub/sub and data operations on the same |
christophstrobl
pushed a commit
that referenced
this pull request
Jul 2, 2019
…nnections. We now use Flux.usingWhen() to apply functions on reactive Redis connections and to release connections calling non-blocking methods. Original Pull Request: #461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use
Flux.usingWhen(…)to apply functions on reactive Redis connections and to release connections calling non-blocking methods.Related ticket: DATAREDIS-999.