-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Apply Nullability to spring-integration-kafka
#10138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
related to spring-projects#10083 Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
related to spring-projects#10083 Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
Please, raise a GH issue in https://github.com/spring-projects/spring-kafka. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple nit-picks.
Overall this is great.
Thank you!
...-kafka/src/main/java/org/springframework/integration/kafka/channel/PollableKafkaChannel.java
Outdated
Show resolved
Hide resolved
...ka/src/main/java/org/springframework/integration/kafka/channel/SubscribableKafkaChannel.java
Outdated
Show resolved
Hide resolved
...n-kafka/src/main/java/org/springframework/integration/kafka/inbound/KafkaInboundGateway.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
in local, I add |
Can you point us to the documentation on the matter, please? |
Ah! I see.
|
Hey, @mjd507 ! Any updates? Thanks |
…into jspecify-kafka
merge |
related to #10083
Suppress warning for child classes which parent class (
RecordMessagingMessageListenerAdapter
orBatchMessagingMessageListenerAdapter
) are inspring-kafka
module, from the parent constructor,(Object bean, Method method)
are non null, but we give(null, null) inspring-integration-kafka
. not sure how to solve it.