Rephrase replication factor documentation #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
spring-builds
pushed a commit
that referenced
this pull request
May 19, 2025
* Fix docs on `RetryableTopic.replicationFactor()` * Rephrase replicationFactor description about broker version Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> (cherry picked from commit ec154a3)
spring-builds
pushed a commit
that referenced
this pull request
May 19, 2025
* Fix docs on `RetryableTopic.replicationFactor()` * Rephrase replicationFactor description about broker version Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> (cherry picked from commit ec154a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetryableTopic- The sentence was not properly separated. I think it was confusing.RetryTopicConfigurationBuilderto match the wording used in other sections, e.g. change historyspring-kafka/spring-kafka-docs/src/main/antora/modules/ROOT/pages/appendix/change-history.adoc
Lines 298 to 299 in b68db55