Skip to content

Fix typo in DaoAuthenticationProvider JavaDoc #12143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rymuff
Copy link
Contributor

@rymuff rymuff commented Nov 6, 2022

Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD

Add misssing {@link

@pivotal-cla
Copy link

@rymuff Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@rymuff Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 6, 2022
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rymuff! Thanks for the PR. I've left a piece of feedback inline.

@jzheaux jzheaux self-assigned this Nov 15, 2022
@jzheaux jzheaux added in: core An issue in spring-security-core type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 15, 2022
rymuff added a commit to rymuff/spring-security that referenced this pull request Nov 15, 2022
@rymuff
Copy link
Contributor Author

rymuff commented Nov 15, 2022

Hi, @jzheaux. Thanks for the feedback and I resolved it.

@jzheaux
Copy link
Contributor

jzheaux commented Nov 15, 2022

Thanks, @rymuff! Will you please also squash your commits? Then I think we're ready to merge.

rymuff added a commit to rymuff/spring-security that referenced this pull request Nov 16, 2022
* Fix typo in JavaDoc

Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD

* feedback resolve

spring-projects#12143 (comment)
spring-projects#12143 (comment)

Fix typo in JavaDoc

Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD
@rymuff
Copy link
Contributor Author

rymuff commented Nov 16, 2022

@jzheaux Done!

@jzheaux jzheaux changed the title Fix typo in JavaDoc Fix typo in DaoAuthenticationProvider JavaDoc Nov 17, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Nov 17, 2022

@rymuff, it looks like the PR build is failing due to formatting. Thanks for sticking with this, I realize it feels like several steps when it is a small change.

If you still have time, will you please run the following on the code so that it adjusts the formatting to meet the project guidelines:

./gradle format

Then, please squash again. If you are out of time, let me know and I'll make the change myself.

@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Nov 18, 2022
@rymuff
Copy link
Contributor Author

rymuff commented Nov 21, 2022

@jzheaux Would you please make the change? sorry for bothering you.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 21, 2022
jzheaux added a commit that referenced this pull request Nov 30, 2022
@jzheaux jzheaux closed this in 709de43 Nov 30, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Nov 30, 2022

No problem, @rymuff. Thanks for the contribution and hope to see you contribute more!

@jzheaux jzheaux added this to the 5.6.10 milestone Nov 30, 2022
@jzheaux jzheaux added status: duplicate A duplicate of another issue and removed status: feedback-provided Feedback has been provided labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants