-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fix typo in DaoAuthenticationProvider JavaDoc #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rymuff Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@rymuff Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @rymuff! Thanks for the PR. I've left a piece of feedback inline.
...src/main/java/org/springframework/security/authentication/dao/DaoAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
Hi, @jzheaux. Thanks for the feedback and I resolved it. |
Thanks, @rymuff! Will you please also squash your commits? Then I think we're ready to merge. |
* Fix typo in JavaDoc Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD * feedback resolve spring-projects#12143 (comment)
spring-projects#12143 (comment) Fix typo in JavaDoc Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD
@jzheaux Done! |
@rymuff, it looks like the PR build is failing due to formatting. Thanks for sticking with this, I realize it feels like several steps when it is a small change. If you still have time, will you please run the following on the code so that it adjusts the formatting to meet the project guidelines:
Then, please squash again. If you are out of time, let me know and I'll make the change myself. |
@jzheaux Would you please make the change? sorry for bothering you. |
No problem, @rymuff. Thanks for the contribution and hope to see you contribute more! |
Fix typo in JavaDoc of USER_NOT_FOUND_PASSWORD
Add misssing
{@link