Support for @Positive #3001
Merged
Support for @Positive #3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonLau88
approved these changes
May 27, 2025
kdebski85
reviewed
Jun 4, 2025
| @@ -189,6 +190,9 @@ public static boolean fieldRequired(Field field, @Nullable io.swagger.v3.oas.ann | |||
| public static void applyValidationsToSchema(Schema<?> schema, List<Annotation> annotations) { | |||
| annotations.forEach(anno -> { | |||
| String annotationName = anno.annotationType().getSimpleName(); | |||
| if (annotationName.equals(Positive.class.getSimpleName())) { | |||
| schema.setMinimum(BigDecimal.ONE); | |||
There was a problem hiding this comment.
Value BigDecimal.ONE is valid only for integers.
For decimals, for example, we can have a valid value 0.00001.
There was a problem hiding this comment.
I think the right approach is schema.setExclusiveMinimumValue(BigDecimal.ZERO);
However, according to https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-models/src/main/java/io/swagger/v3/oas/models/media/Schema.java#L441 it is supported only in OpenAPI 3.1.
|
@bnasslahsen Any reason it was merged? |
|
@mpleine Are you going to prepare another PR that would fix it for decimals? |
|
I can see it was fixed in 6c3aa8f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for @positive annotation validation constraint
When merged, the following documentation should be updated also
Suggestion:
Maybe there could be a complete list in the documentation, which validation annotations are currently supported (and the ones that are not listed there, are currently not supported)