Skip to content

Use address type (IP vs DNS) configured by ListenerClass #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 9, 2024

Description

Fixes #139, requires stackabletech/operator-rs#885

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr nightkr removed the request for review from a team October 9, 2024 12:19
@sbernauer sbernauer self-requested a review October 9, 2024 12:40
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, did not test it yet

sbernauer
sbernauer previously approved these changes Oct 10, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we only need the op-rs release

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's use main for now

@sbernauer
Copy link
Member

I would like to start a weekly test-run for all products after the merge, so that we see if it causes any problems.

@nightkr nightkr added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit bdb4e8b Oct 17, 2024
31 checks passed
@nightkr nightkr deleted the feature/listenerclass-preferred-address-type branch October 17, 2024 13:36
@sbernauer
Copy link
Member

@nightkr good news: I ran 5 tests ,only https://testing.stackable.tech/job/hdfs-operator-it-weekly/17/ failed - which seems like flakiness :)
Get "[https://cluster-dns-n9acebml.hcp.eastus.azmk8s.io:443/apis/batch/v1/namespaces/kuttl-test-wealthy-liger/jobs/access-hdfs](https://cluster-dns-n9acebml.hcp.eastus.azmk8s.io/apis/batch/v1/namespaces/kuttl-test-wealthy-liger/jobs/access-hdfs)": dial tcp: lookup cluster-dns-n9acebml.hcp.eastus.azmk8s.io on 8.8.8.8:53: no such host

@nightkr
Copy link
Member Author

nightkr commented Oct 18, 2024

:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow listenerclasses to specify whether to prefer IP or Hostname addresses
3 participants