-
Notifications
You must be signed in to change notification settings - Fork 1
Use address type (IP vs DNS) configured by ListenerClass #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, did not test it yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we only need the op-rs release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's use main for now
I would like to start a weekly test-run for all products after the merge, so that we see if it causes any problems. |
@nightkr good news: I ran 5 tests ,only https://testing.stackable.tech/job/hdfs-operator-it-weekly/17/ failed - which seems like flakiness :) |
:/ |
Description
Fixes #139, requires stackabletech/operator-rs#885
Definition of Done Checklist